Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TrustZone message to extract Cluster #126

Open
markgoddard opened this issue Jan 17, 2025 · 0 comments · May be fixed by #130
Open

Refactor TrustZone message to extract Cluster #126

markgoddard opened this issue Jan 17, 2025 · 0 comments · May be fixed by #130
Assignees
@markgoddard
Milestone
release-0.9.0

Comments

@markgoddard
Copy link
Contributor

First step towards #76 - refactor the proto messages without changing behaviour, UI, data source etc.
@markgoddard markgoddard self-assigned this Jan 17, 2025
@markgoddard markgoddard added this to the release-0.9.0 milestone Jan 17, 2025
@markgoddard markgoddard mentioned this issue Jan 17, 2025
Open
markgoddard added a commit that referenced this issue Jan 17, 2025
@markgoddard
Separate Cluster message from TrustZone
b3c47f2 
This change modifies cofidectl to adapt to the changes in
cofide/cofide-api-sdk#25, in which the TrustZone
message has been refactored to extract per-Kubernetes cluster details
into a Cluster message.

For now we restrict the number of clusters per trust zone to one.
Clusters are not yet exposed by the CLI as separate from trust zones.
They are currently embedded into trust zones in the data model but will
be referenced by name or ID in future.

Fixes: #126
@markgoddard markgoddard linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markgoddard markgoddard

Labels
None yet
Projects
None yet
Milestone
release-0.9.0
Development

Successfully merging a pull request may close this issue.

Separate Cluster message from TrustZone cofide/cofidectl
1 participant
@markgoddard