Refactor TrustZone to extract a repeated Cluster message #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backward incompatible change, but worthwhile after the cluster refactor.
|
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
markgoddard
commented
Jan 17, 2025
nialdaly
approved these changes
Jan 17, 2025
markgoddard
added a commit
to cofide/cofidectl
that referenced
this pull request
Jan 17, 2025
This change modifies cofidectl to adapt to the changes in cofide/cofide-api-sdk#25, in which the TrustZone message has been refactored to extract per-Kubernetes cluster details into a Cluster message. For now we restrict the number of clusters per trust zone to one. Clusters are not yet exposed by the CLI as separate from trust zones. They are currently embedded into trust zones in the data model but will be referenced by name or ID in future. Fixes: #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the TrustZone message to extract per-Kubernetes cluster details into a Cluster message. They are currently embedded into the TrustZone message as a repeated field, but will eventually be referenced by name or ID.
The Cluster.kubernetes_cluster field has been renamed to Cluster.name.
Field numbers in the TrustZone message have been defragmented.
Required for cofide/cofidectl#126