feat: add filter to check invalid chars in user input #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
add-filter-invalidChars
branch
from
837f37b to
44db72b
Compare
MGatner
requested changes
Oct 22, 2021
Member
|
Great security addition! Made a few notes. I wonder if we should ship this on by default? Since it would be a change to app/ we can afford to do it without affecting existing projects. Have you benchmarked this or checked Debug Toolbar timelines to see impact? |
MGatner
approved these changes
Nov 6, 2021
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Thanks for those changes, looks great!
The following test failed. It depends global state. 1) CodeIgniter\HTTP\ResponseTest::testSetLink Failed asserting that two strings are identical.
kenjis
force-pushed
the
add-filter-invalidChars
branch
from
0633964 to
78c2150
Compare
Users could override the property.
kenjis
force-pushed
the
add-filter-invalidChars
branch
from
78c2150 to
fb9f6ec
Compare
Member
Author
|
@MGatner I rebased this PR and added 3 commits.
I saw Debug Toolbar timelines, but small input does not impact. |
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
paulbalandan
approved these changes
Nov 23, 2021
Member
|
💪😊👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: