@@ -69,25 +69,27 @@ private function createRequest(): IncomingRequest
6969 return $ request ;
7070 }
7171
72+ /**
73+ * @doesNotPerformAssertions
74+ */
7275 public function testBeforeDoNothingWhenCLIRequest ()
7376 {
7477 $ cliRequest = new CLIRequest (new MockAppConfig ());
7578
76- $ ret = $ this ->invalidChars ->before ($ cliRequest );
77-
78- $ this ->assertNull ($ ret );
79+ $ this ->invalidChars ->before ($ cliRequest );
7980 }
8081
82+ /**
83+ * @doesNotPerformAssertions
84+ */
8185 public function testBeforeValidString ()
8286 {
8387 $ _POST ['val ' ] = [
8488 'valid string ' ,
8589 ];
8690 $ _COOKIE ['val ' ] = 'valid string ' ;
8791
88- $ ret = $ this ->invalidChars ->before ($ this ->request );
89-
90- $ this ->assertNull ($ ret );
92+ $ this ->invalidChars ->before ($ this ->request );
9193 }
9294
9395 public function testBeforeInvalidUTF8StringCausesException ()
@@ -104,7 +106,7 @@ public function testBeforeInvalidUTF8StringCausesException()
104106 $ this ->invalidChars ->before ($ this ->request );
105107 }
106108
107- public function testBeforeInvalidControllCharCausesException ()
109+ public function testBeforeInvalidControlCharCausesException ()
108110 {
109111 $ this ->expectException (SecurityException::class);
110112 $ this ->expectExceptionMessage ('Invalid Control characters in cookie: ' );
@@ -116,6 +118,8 @@ public function testBeforeInvalidControllCharCausesException()
116118 }
117119
118120 /**
121+ * @doesNotPerformAssertions
122+ *
119123 * @dataProvider stringWithLineBreakAndTabProvider
120124 *
121125 * @param string $input
@@ -124,9 +128,7 @@ public function testCheckControlStringWithLineBreakAndTabReturnsTheString($input
124128 {
125129 $ _GET ['val ' ] = $ input ;
126130
127- $ ret = $ this ->invalidChars ->before ($ this ->request );
128-
129- $ this ->assertNull ($ ret );
131+ $ this ->invalidChars ->before ($ this ->request );
130132 }
131133
132134 public function stringWithLineBreakAndTabProvider ()
@@ -152,9 +154,7 @@ public function testCheckControlStringWithControlCharsCausesException($input)
152154
153155 $ _GET ['val ' ] = $ input ;
154156
155- $ ret = $ this ->invalidChars ->before ($ this ->request );
156-
157- $ this ->assertNull ($ ret );
157+ $ this ->invalidChars ->before ($ this ->request );
158158 }
159159
160160 public function stringWithControlCharsProvider ()
0 commit comments