Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused events #93

Merged
merged 2 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions services/notification/notifiers/mixins/message/sections.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,9 @@
from itertools import starmap
from typing import List

from shared.analytics_tracking import (
track_critical_files_sent,
track_related_entrypoints_sent,
)
from shared.helpers.yaml import walk
from shared.reports.resources import Report

from helpers.environment import is_enterprise
from helpers.reports import get_totals_from_file_in_reports
from services.comparison import ComparisonProxy
from services.comparison.overlays import OverlayType
Expand Down Expand Up @@ -248,13 +243,6 @@ async def do_write_section(self, comparison, diff, changes, links, behind_by=Non
yield (
"Changes have been made to critical files, which contain lines commonly executed in production. [Learn more](https://docs.codecov.com/docs/impact-analysis)"
)
track_critical_files_sent(
self.repository.repoid,
self.repository.ownerid,
comparison.head.commit.commitid,
pull.pullid,
is_enterprise(),
)


class HeaderSectionWriter(BaseSectionWriter):
Expand Down Expand Up @@ -361,13 +349,6 @@ async def do_write_section(self, comparison, diff, changes, links, behind_by=Non
yield (
"Changes have been made to critical files, which contain lines commonly executed in production. [Learn more](https://docs.codecov.com/docs/impact-analysis)"
)
track_critical_files_sent(
self.repository.repoid,
self.repository.ownerid,
comparison.head.commit.commitid,
pull.pullid,
is_enterprise(),
)


class AnnouncementSectionWriter(BaseSectionWriter):
Expand All @@ -393,13 +374,6 @@ async def do_write_section(self, comparison, diff, changes, links, behind_by=Non
yield "|---|"
for endpoint in impacted_endpoints:
yield (f"|{endpoint['group_name']}|")
track_related_entrypoints_sent(
self.repository.repoid,
self.repository.ownerid,
comparison.head.commit.commitid,
comparison.pull.pullid,
is_enterprise(),
)
elif impacted_endpoints is not None:
yield "This change has been scanned for critical changes. [Learn more](https://docs.codecov.com/docs/impact-analysis)"

Expand Down
15 changes: 0 additions & 15 deletions services/notification/notifiers/status/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
from contextlib import nullcontext
from typing import Dict

from shared.analytics_tracking import track_event
from shared.config import get_config
from shared.torngit.exceptions import TorngitClientError, TorngitError
from shared.utils.sessions import SessionType

from helpers.cache import DEFAULT_TTL, NO_VALUE, cache, make_hash_sha256
from helpers.environment import is_enterprise
from helpers.match import match
from helpers.metrics import metrics
from services.comparison import ComparisonProxy
Expand Down Expand Up @@ -318,19 +316,6 @@ async def send_notification(self, comparison: Comparison, payload):
"success" if self.notifier_yaml_settings.get("informational") else state
)

# Track state in analytics
event_name = (
"Coverage Report Passed"
if state == "success"
else "Coverage Report Failed"
)
track_event(
user_id=self.repository.ownerid,
event_name=event_name,
is_enterprise=is_enterprise(),
event_data={"state": state, "repository_id": self.repository.repoid},
)

notification_result_data_sent = {
"title": title,
"state": state,
Expand Down
91 changes: 39 additions & 52 deletions services/notification/notifiers/tests/unit/test_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -599,63 +599,50 @@ async def test_send_notification(
async def test_notify_analytics(
self, sample_comparison, mocker, mock_repo_provider
):
with patch("shared.analytics_tracking.analytics.track") as mock_track:
mocker.patch("helpers.environment.is_enterprise", return_value=False)
comparison = sample_comparison
no_settings_notifier = StatusNotifier(
repository=comparison.head.commit.repository,
title="title",
notifier_yaml_settings={},
notifier_site_settings=True,
current_yaml=UserYaml({}),
)
no_settings_notifier.context = "fake"
mocked_status_already_exists = mocker.patch.object(
StatusNotifier, "status_already_exists"
)
mocked_status_already_exists.return_value = False
mock_repo_provider.set_commit_status.side_effect = TorngitClientError(
403, "response", "message"
)
payload = {"message": "something to say", "state": "success", "url": "url"}
await no_settings_notifier.send_notification(comparison, payload)
assert mock_track.called_with(
15,
"Coverage Report Passed",
{"state": "success", "repository_id": 6},
False,
)

mocker.patch("helpers.environment.is_enterprise", return_value=False)
comparison = sample_comparison
no_settings_notifier = StatusNotifier(
repository=comparison.head.commit.repository,
title="title",
notifier_yaml_settings={},
notifier_site_settings=True,
current_yaml=UserYaml({}),
)
no_settings_notifier.context = "fake"
mocked_status_already_exists = mocker.patch.object(
StatusNotifier, "status_already_exists"
)
mocked_status_already_exists.return_value = False
mock_repo_provider.set_commit_status.side_effect = TorngitClientError(
403, "response", "message"
)
payload = {"message": "something to say", "state": "success", "url": "url"}
await no_settings_notifier.send_notification(comparison, payload)

@pytest.mark.asyncio
async def test_notify_analytics_enterprise(
self, sample_comparison, mocker, mock_repo_provider
):
with patch("shared.analytics_tracking.analytics.track") as mock_track:
mocker.patch("helpers.environment.is_enterprise", return_value=True)
comparison = sample_comparison
no_settings_notifier = StatusNotifier(
repository=comparison.head.commit.repository,
title="title",
notifier_yaml_settings={},
notifier_site_settings=True,
current_yaml=UserYaml({}),
)
no_settings_notifier.context = "fake"
mocked_status_already_exists = mocker.patch.object(
StatusNotifier, "status_already_exists"
)
mocked_status_already_exists.return_value = False
mock_repo_provider.set_commit_status.side_effect = TorngitClientError(
403, "response", "message"
)
payload = {"message": "something to say", "state": "success", "url": "url"}
await no_settings_notifier.send_notification(comparison, payload)
assert mock_track.called_with(
15,
"Coverage Report Passed",
{"state": "success", "repository_id": 6},
True,
)
mocker.patch("helpers.environment.is_enterprise", return_value=True)
comparison = sample_comparison
no_settings_notifier = StatusNotifier(
repository=comparison.head.commit.repository,
title="title",
notifier_yaml_settings={},
notifier_site_settings=True,
current_yaml=UserYaml({}),
)
no_settings_notifier.context = "fake"
mocked_status_already_exists = mocker.patch.object(
StatusNotifier, "status_already_exists"
)
mocked_status_already_exists.return_value = False
mock_repo_provider.set_commit_status.side_effect = TorngitClientError(
403, "response", "message"
)
payload = {"message": "something to say", "state": "success", "url": "url"}
await no_settings_notifier.send_notification(comparison, payload)

def test_determine_status_check_behavior_to_apply(self, sample_comparison):
# uses component level setting if provided
Expand Down
2 changes: 0 additions & 2 deletions services/yaml/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from helpers.save_commit_error import save_commit_error
from services.yaml.fetcher import fetch_commit_yaml_from_provider
from services.yaml.reader import read_yaml_field
from services.yaml.tracking import tracking_yaml_fields_changes

log = logging.getLogger(__name__)

Expand Down Expand Up @@ -111,7 +110,6 @@ def save_repo_yaml_to_database_if_needed(current_commit, new_yaml):
current_commit.repository.branch,
read_yaml_field(existing_yaml, ("codecov", "branch")),
)
tracking_yaml_fields_changes(existing_yaml, new_yaml, repository)
if current_commit.branch and current_commit.branch in branches_considered_for_yaml:
if not syb or syb == current_commit.branch:
yaml_branch = read_yaml_field(new_yaml, ("codecov", "branch"))
Expand Down
139 changes: 0 additions & 139 deletions services/yaml/tests/test_yaml_tracking.py

This file was deleted.

Loading