removing unused events #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-yaish
force-pushed
the
dana/remove-unused-events
branch
from
56abab6
to
0bb6847
Compare
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 98.48% 98.48% -0.01%
==========================================
Files 364 364
Lines 26827 26812 -15
==========================================
- Hits 26421 26406 -15
Misses 406 406
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Sep 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 98.45% 98.44% -0.01%
==========================================
Files 345 343 -2
Lines 26764 26640 -124
==========================================
- Hits 26351 26227 -124
Misses 413 413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 98.45% 98.44% -0.01%
==========================================
Files 345 343 -2
Lines 26764 26640 -124
==========================================
- Hits 26351 26227 -124
Misses 413 413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paul has stated that we're tracking events we don't really use. So removing them from the codebase. You can see the events that we use in this notion doc which has a spreadsheet link that summarizes it https://www.notion.so/sentry/Codecov-Segment-deprecation-handling-events-62cb4c0e1d2f41cf865140d676aa02f6#afa2ebf934f344afb8c9e92b4f7d22e7
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.