Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add promotional message for new message to end of PR comment #754

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Merge branch 'main' of github.com:codecov/worker into joseph/new-feat…

dbb63e3
Select commit
Loading
Failed to load commit list.
Open

feat: add promotional message for new message to end of PR comment #754

Merge branch 'main' of github.com:codecov/worker into joseph/new-feat…
dbb63e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 12, 2024 in 1s

90.75% (-7.26%) compared to 0d27b33

View this Pull Request on Codecov

90.75% (-7.26%) compared to 0d27b33

Details

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (0d27b33) to head (dbb63e3).

Files with missing lines Patch % Lines
.../notification/notifiers/tests/unit/test_comment.py 20.68% 23 Missing ⚠️
.../notification/notifiers/mixins/message/__init__.py 50.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0d27b33) and HEAD (dbb63e3). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0d27b33) HEAD (dbb63e3)
unit 2 1
integration 2 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   98.00%   90.75%   -7.26%     
==========================================
  Files         444      444              
  Lines       35410    35449      +39     
==========================================
- Hits        34705    32170    -2535     
- Misses        705     3279    +2574     
Components Coverage Δ
NonTestCode 90.68% <55.55%> (-5.37%) ⬇️
OutsideTasks 95.75% <30.76%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
database/models/core.py 96.52% <100.00%> (-1.26%) ⬇️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 96.36% <50.00%> (-3.64%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 98.21% <20.68%> (-1.79%) ⬇️

... and 57 files with indirect coverage changes