Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add promotional message for new message to end of PR comment #754

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add promotional message for new message to end of PR comment #754

wants to merge 5 commits into from

Conversation

joseph-sentry
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@joseph-sentry joseph-sentry requested a review from a team October 2, 2024 14:51
@codecov-staging
Copy link

codecov-staging bot commented Oct 2, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../notification/notifiers/tests/unit/test_comment.py 20.68% 23 Missing ⚠️
.../notification/notifiers/mixins/message/__init__.py 50.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0d27b33) and HEAD (dbb63e3). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0d27b33) HEAD (dbb63e3)
unit 2 1
integration 2 0

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   98.00%   90.75%   -7.26%     
==========================================
  Files         444      444              
  Lines       35410    35449      +39     
==========================================
- Hits        34705    32170    -2535     
- Misses        705     3279    +2574
Flag Coverage Δ
integration ?
unit 90.75% <30.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.68% <55.55%> (-5.37%) ⬇️
OutsideTasks 95.75% <30.76%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
database/models/core.py 96.52% <100.00%> (-1.26%) ⬇️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 96.36% <50.00%> (-3.64%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 98.21% <20.68%> (-1.79%) ⬇️

... and 57 files with indirect coverage changes

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (0d27b33) to head (dbb63e3).

Files with missing lines Patch % Lines
.../notification/notifiers/tests/unit/test_comment.py 20.68% 23 Missing ⚠️
.../notification/notifiers/mixins/message/__init__.py 50.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0d27b33) and HEAD (dbb63e3). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0d27b33) HEAD (dbb63e3)
unit 2 1
integration 2 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   98.00%   90.75%   -7.26%     
==========================================
  Files         444      444              
  Lines       35410    35449      +39     
==========================================
- Hits        34705    32170    -2535     
- Misses        705     3279    +2574
Flag Coverage Δ
integration ?
unit 90.75% <30.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.68% <55.55%> (-5.37%) ⬇️
OutsideTasks 95.75% <30.76%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
database/models/core.py 96.52% <100.00%> (-1.26%) ⬇️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 96.36% <50.00%> (-3.64%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 98.21% <20.68%> (-1.79%) ⬇️

... and 57 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (0d27b33) to head (dbb63e3).

Files with missing lines Patch % Lines
.../notification/notifiers/tests/unit/test_comment.py 20.68% 23 Missing ⚠️
.../notification/notifiers/mixins/message/__init__.py 50.00% 4 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   98.00%   90.75%   -7.26%     
==========================================
  Files         444      444              
  Lines       35410    35449      +39     
==========================================
- Hits        34705    32170    -2535     
- Misses        705     3279    +2574
Flag Coverage Δ
integration ?
unit 90.75% <30.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.68% <55.55%> (-5.37%) ⬇️
OutsideTasks 95.75% <30.76%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
database/models/core.py 96.52% <100.00%> (-1.26%) ⬇️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 96.36% <50.00%> (-3.64%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 98.21% <20.68%> (-1.79%) ⬇️

... and 57 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (0d27b33) to head (dbb63e3).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   98.00%   90.75%   -7.26%     
==========================================
  Files         444      444              
  Lines       35410    35449      +39     
==========================================
- Hits        34705    32170    -2535     
- Misses        705     3279    +2574
Flag Coverage Δ
integration ?
unit 90.75% <30.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.68% <55.55%> (-5.37%) ⬇️
OutsideTasks 95.75% <30.76%> (-0.11%) ⬇️
Files Coverage Δ
database/models/core.py 96.52% <100.00%> (-1.26%) ⬇️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 96.36% <50.00%> (-3.64%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 98.21% <20.68%> (-1.79%) ⬇️

... and 57 files with indirect coverage changes

@github-actions GitHub Actions
Copy link

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
1656 4 1651 1
View the top 3 failed tests by shortest run time 
test_build_message_new_feature_message[False-True]
Stack Traces | 0.076s run time 
self = &lt;test_comment.TestCommentNotifier object at 0x7f5a5cfa6150&gt;
dbsession = &lt;sqlalchemy.orm.session.Session object at 0x7f5a4c9b76b0&gt;
mock_configuration = &lt;shared.config.ConfigHelper object at 0x7f5a4d52f8c0&gt;
mock_repo_provider = &lt;MagicMock name='_get_repo_provider_service_instance()' spec='Github' id='140025822398080'&gt;
sample_comparison = &lt;services.comparison.ComparisonProxy object at 0x7f5a3c60aea0&gt;
test_analytics_enabled = False, bundle_analysis_enabled = True

    @pytest.mark.parametrize(
        "test_analytics_enabled,bundle_analysis_enabled",
        [(False, False), (False, True), (True, False), (True, True)],
    )
    def test_build_message_new_feature_message(
        self,
        dbsession,
        mock_configuration,
        mock_repo_provider,
        sample_comparison,
        test_analytics_enabled,
        bundle_analysis_enabled,
    ):
        mock_configuration.params["setup"]["codecov_dashboard_url"] = "test.example.br"
        comparison = sample_comparison
        pull = comparison.pull
&gt;       notifier = CommentNotifier(
            repository=sample_comparison.head.commit.repository,
            title="title",
            notifier_yaml_settings={"layout": "reach, diff, flags, files, footer"},
            notifier_site_settings=True,
            current_yaml={},
        )
E       TypeError: AbstractBaseNotifier.__init__() missing 1 required positional argument: 'repository_service'

services/notification/notifiers/tests/unit/test_comment.py:3056: TypeError

test_build_message_new_feature_message[True-False]
Stack Traces | 0.076s run time 
self = &lt;test_comment.TestCommentNotifier object at 0x7f5a5cfa6210&gt;
dbsession = &lt;sqlalchemy.orm.session.Session object at 0x7f5a3c60b050&gt;
mock_configuration = &lt;shared.config.ConfigHelper object at 0x7f5a3c483b90&gt;
mock_repo_provider = &lt;MagicMock name='_get_repo_provider_service_instance()' spec='Github' id='140025814705520'&gt;
sample_comparison = &lt;services.comparison.ComparisonProxy object at 0x7f5a4cf9c3b0&gt;
test_analytics_enabled = True, bundle_analysis_enabled = False

    @pytest.mark.parametrize(
        "test_analytics_enabled,bundle_analysis_enabled",
        [(False, False), (False, True), (True, False), (True, True)],
    )
    def test_build_message_new_feature_message(
        self,
        dbsession,
        mock_configuration,
        mock_repo_provider,
        sample_comparison,
        test_analytics_enabled,
        bundle_analysis_enabled,
    ):
        mock_configuration.params["setup"]["codecov_dashboard_url"] = "test.example.br"
        comparison = sample_comparison
        pull = comparison.pull
&gt;       notifier = CommentNotifier(
            repository=sample_comparison.head.commit.repository,
            title="title",
            notifier_yaml_settings={"layout": "reach, diff, flags, files, footer"},
            notifier_site_settings=True,
            current_yaml={},
        )
E       TypeError: AbstractBaseNotifier.__init__() missing 1 required positional argument: 'repository_service'

services/notification/notifiers/tests/unit/test_comment.py:3056: TypeError

test_build_message_new_feature_message[True-True]
Stack Traces | 0.076s run time 
self = &lt;test_comment.TestCommentNotifier object at 0x7f5a5cfa62d0&gt;
dbsession = &lt;sqlalchemy.orm.session.Session object at 0x7f5a4d7bed20&gt;
mock_configuration = &lt;shared.config.ConfigHelper object at 0x7f5a4d675700&gt;
mock_repo_provider = &lt;MagicMock name='_get_repo_provider_service_instance()' spec='Github' id='140025809107136'&gt;
sample_comparison = &lt;services.comparison.ComparisonProxy object at 0x7f5a4d6d07a0&gt;
test_analytics_enabled = True, bundle_analysis_enabled = True

    @pytest.mark.parametrize(
        "test_analytics_enabled,bundle_analysis_enabled",
        [(False, False), (False, True), (True, False), (True, True)],
    )
    def test_build_message_new_feature_message(
        self,
        dbsession,
        mock_configuration,
        mock_repo_provider,
        sample_comparison,
        test_analytics_enabled,
        bundle_analysis_enabled,
    ):
        mock_configuration.params["setup"]["codecov_dashboard_url"] = "test.example.br"
        comparison = sample_comparison
        pull = comparison.pull
&gt;       notifier = CommentNotifier(
            repository=sample_comparison.head.commit.repository,
            title="title",
            notifier_yaml_settings={"layout": "reach, diff, flags, files, footer"},
            notifier_site_settings=True,
            current_yaml={},
        )
E       TypeError: AbstractBaseNotifier.__init__() missing 1 required positional argument: 'repository_service'

services/notification/notifiers/tests/unit/test_comment.py:3056: TypeError

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @Swatinem