Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing log for not scheduling notify #64

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Add missing log for not scheduling notify #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tasks/upload_finisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,17 @@ def should_call_notifications(
if not any(
x["successful"] for x in processing_results.get("processings_so_far", [])
):
log.info(
"Not scheduling notify because there are no successful processing results",
extra=dict(
repoid=commit.repoid,
commit=commit.commitid,
commit_yaml=commit_yaml,
processing_results=processing_results,
report_code=report_code,
parent_task=self.request.parent_id,
),
)
return False

after_n_builds = (
Expand Down
Loading