Add missing log for not scheduling notify #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 361 361
Lines 26476 26477 +1
=======================================
+ Hits 26072 26073 +1
Misses 404 404
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
joseph-sentry
requested review from
dana-yaish,
giovanni-guidini and
scott-codecov
scott-codecov
approved these changes
Sep 5, 2023
Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/finisher-log-improvement
branch
from
0e021bc
to
114f36f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for not scheduling the notify was missing here, which was confusing.