Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link flag and component names in PR comment back to dashboard pages #61

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov force-pushed the scott/pr-comment-flag-component-links branch 2 times, most recently from 307efa8 to 44308af Compare August 14, 2023 15:11
@scott-codecov scott-codecov force-pushed the scott/pr-comment-flag-component-links branch from 44308af to b3142a8 Compare August 14, 2023 15:18
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #61 (b3142a8) into main (319753b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files         357      357           
  Lines       25943    25943           
=======================================
  Hits        25584    25584           
  Misses        359      359           
Flag Coverage Δ
integration 98.58% <100.00%> (ø)
latest-uploader-overall 98.58% <100.00%> (ø)
onlysomelabels 98.61% <100.00%> (ø)
unit 98.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.36% <100.00%> (ø)
OutsideTasks 98.35% <100.00%> (ø)
Files Changed Coverage Δ
...cation/notifiers/tests/integration/test_comment.py 100.00% <ø> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <ø> (ø)
.../notification/notifiers/mixins/message/sections.py 99.63% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

Copy link
Contributor

@dana-yaish dana-yaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-codecov scott-codecov merged commit cd7259c into main Aug 14, 2023
12 checks passed
@scott-codecov scott-codecov deleted the scott/pr-comment-flag-component-links branch August 14, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor components/flags directly to sections in-app
2 participants