-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Link flag and component names in PR comment back to dashboard p…
…ages
- Loading branch information
1 parent
319753b
commit 44308af
Showing
3 changed files
with
95 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -364,10 +364,10 @@ async def test_notify(self, sample_comparison, codecov_vcr, mock_configuration): | |
"- Partials 0 1 +1 ", | ||
"```", | ||
"", | ||
"| Flag | Coverage Δ | Complexity Δ | |", | ||
"| [Flag](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flags) | Coverage Δ | Complexity Δ | |", | ||
"|---|---|---|---|", | ||
"| integration | `?` | `?` | |", | ||
"| unit | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"| [integration](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flag) | `?` | `?` | |", | ||
"| [unit](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flag) | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"", | ||
"Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.", | ||
"", | ||
|
@@ -431,7 +431,7 @@ async def test_notify_upload_limited( | |
): | ||
mock_configuration._params["setup"] = { | ||
"codecov_url": None, | ||
"codecov_dashboard_url": "test.example.br", | ||
"codecov_dashboard_url": "https://app.codecov.io", | ||
} | ||
comparison = sample_comparison_for_limited_upload | ||
notifier = CommentNotifier( | ||
|
@@ -447,10 +447,10 @@ async def test_notify_upload_limited( | |
assert result.notification_successful | ||
assert result.explanation is None | ||
expected_message = [ | ||
f"## [Codecov](test.example.br/plan/gh/test-acc9) upload limit reached :warning:", | ||
f"## [Codecov](https://app.codecov.io/plan/gh/test-acc9) upload limit reached :warning:", | ||
f"This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month.\ | ||
This limit has been reached and additional reports cannot be generated. For unlimited uploads,\ | ||
upgrade to our [pro plan](test.example.br/plan/gh/test-acc9).", | ||
upgrade to our [pro plan](https://app.codecov.io/plan/gh/test-acc9).", | ||
f"", | ||
f"**Do you have questions or need help?** Connect with our sales team today at ` [email protected] `", | ||
] | ||
|
@@ -507,10 +507,10 @@ async def test_notify_gitlab( | |
"- Partials 0 1 +1 ", | ||
"```", | ||
"", | ||
"| Flag | Coverage Δ | Complexity Δ | |", | ||
"| [Flag](https://app.codecov.io/gl/joseph-sentry/example-python/pull/1/flags?src=pr&el=flags) | Coverage Δ | Complexity Δ | |", | ||
"|---|---|---|---|", | ||
"| integration | `?` | `?` | |", | ||
"| unit | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"| [integration](https://app.codecov.io/gl/joseph-sentry/example-python/pull/1/flags?src=pr&el=flag) | `?` | `?` | |", | ||
"| [unit](https://app.codecov.io/gl/joseph-sentry/example-python/pull/1/flags?src=pr&el=flag) | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"", | ||
"Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.", | ||
"", | ||
|
@@ -578,10 +578,10 @@ async def test_notify_new_layout( | |
"- Partials 0 1 +1 ", | ||
"```", | ||
"", | ||
"| Flag | Coverage Δ | Complexity Δ | |", | ||
"| [Flag](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flags) | Coverage Δ | Complexity Δ | |", | ||
"|---|---|---|---|", | ||
"| integration | `?` | `?` | |", | ||
"| unit | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"| [integration](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flag) | `?` | `?` | |", | ||
"| [unit](https://app.codecov.io/gh/ThiagoCodecov/example-python/pull/15/flags?src=pr&el=flag) | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"", | ||
"Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.", | ||
"", | ||
|
@@ -653,18 +653,18 @@ async def test_notify_with_components( | |
"- Partials 0 1 +1 ", | ||
"```", | ||
"", | ||
"| Flag | Coverage Δ | Complexity Δ | |", | ||
"| [Flag](https://app.codecov.io/gh/codecove2e/example-python/pull/4/flags?src=pr&el=flags) | Coverage Δ | Complexity Δ | |", | ||
"|---|---|---|---|", | ||
"| integration | `?` | `?` | |", | ||
"| unit | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"| [integration](https://app.codecov.io/gh/codecove2e/example-python/pull/4/flags?src=pr&el=flag) | `?` | `?` | |", | ||
"| [unit](https://app.codecov.io/gh/codecove2e/example-python/pull/4/flags?src=pr&el=flag) | `100.00% <ø> (?)` | `0.00 <ø> (?)` | |", | ||
"", | ||
"Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.", | ||
"", | ||
"[see 2 files with indirect coverage changes](https://app.codecov.io/gh/codecove2e/example-python/pull/4/indirect-changes?src=pr&el=tree-more)", | ||
"", | ||
"| Components | Coverage Δ | |", | ||
"| [Components](https://app.codecov.io/gh/codecove2e/example-python/pull/4/components?src=pr&el=components) | Coverage Δ | |", | ||
"|---|---|---|", | ||
"| go_files | `62.50% <ø> (+12.50%)` | :arrow_up: |", | ||
"| [go_files](https://app.codecov.io/gh/codecove2e/example-python/pull/4/components?src=pr&el=component) | `62.50% <ø> (+12.50%)` | :arrow_up: |", | ||
"", | ||
"</details>", | ||
"", | ||
|
Oops, something went wrong.