Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add E, PLC, and PLE ruff rules #505

Merged
merged 1 commit into from
Jun 20, 2024

add E, PLC, and PLE ruff rules, fix errors

157e946
Select commit
Loading
Failed to load commit list.
Merged

dev: Add E, PLC, and PLE ruff rules #505

add E, PLC, and PLE ruff rules, fix errors
157e946
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 17, 2024 in 0s

97.48% (-0.01%) compared to 4840ca4, passed because coverage increased by -0.01% when compared to adjusted base (97.48%)

View this Pull Request on Codecov

97.48% (-0.01%) compared to 4840ca4, passed because coverage increased by -0.01% when compared to adjusted base (97.48%)

Details

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.48%. Comparing base (4840ca4) to head (157e946).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   97.48%   97.48%   -0.01%     
==========================================
  Files         447      447              
  Lines       35488    35493       +5     
==========================================
+ Hits        34595    34599       +4     
- Misses        893      894       +1     
Components Coverage Δ
NonTestCode 94.50% <84.61%> (-0.01%) ⬇️
OutsideTasks 97.72% <96.96%> (-0.01%) ⬇️
Files Coverage Δ
database/models/core.py 97.10% <ø> (ø)
database/tests/unit/test_model_utils.py 100.00% <100.00%> (ø)
helpers/checkpoint_logger/__init__.py Critical 94.68% <100.00%> (+0.02%) ⬆️
helpers/tests/pathmap/test_tree.py 100.00% <100.00%> (ø)
services/commit_status.py 100.00% <100.00%> (ø)
services/github.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
...s/notification/notifiers/mixins/message/helpers.py 92.00% <100.00%> (ø)
...s/notification/notifiers/tests/unit/test_checks.py 100.00% <100.00%> (ø)
...s/notification/notifiers/tests/unit/test_status.py 100.00% <ø> (ø)
... and 28 more
Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.notify.Notify
run/app.tasks.upload.UploadFinisher
run/app.tasks.upload.UploadProcessor