dev: Add E, PLC, and PLE ruff rules #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajay-sentry
commented
Jun 17, 2024
| @@ -16,7 +16,7 @@ | |||
| | 1|line | |||
| 1k| 2|line | |||
| warning: The file '/Users/Jack/Documents/Coupgon/sdk-ios/Source/CPGCoupgonsViewController.swift' isn't covered. | |||
| \033[0;36m/file:\033[0m | |||
| \033\x1b[0;36m/file:\033[0m | |||
There was a problem hiding this comment.
This and the following two files were some broken escape characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 97.45% 97.45% -0.01%
==========================================
Files 416 416
Lines 34759 34764 +5
==========================================
+ Hits 33876 33880 +4
- Misses 883 884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 97.45% 97.45% -0.01%
==========================================
Files 416 416
Lines 34759 34764 +5
==========================================
+ Hits 33876 33880 +4
- Misses 883 884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 97.45% 97.45% -0.01%
==========================================
Files 416 416
Lines 34759 34764 +5
==========================================
+ Hits 33876 33880 +4
- Misses 883 884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 447 447
Lines 35488 35493 +5
==========================================
+ Hits 34595 34599 +4
- Misses 893 894 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matt-codecov
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Part of the lint enhancement epic, this PR aims to add the Pycodestyle error rules, and the Pylint Convention and Pylint Error rules.
These can be found here:
A majority of the fixes were related to E721 (isinstance comparisons), E722 (bare except), E713 (test for membership should be not in), and E711 (Comparison to None should be cond is None)
NOTE: I added ignores to all the SQL Alchemy code because it BREAKS when using is None vs. == None. This is because of how the "SQL" is parsed with == vs. the Python specific "is."
Links to relevant tickets
Closes codecov/engineering-team#1930
What does this PR do?
This PR adds the rules listed above and fixes any errors that stemmed from them.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.