Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve adjusted base comparison #484

Merged
merged 1 commit into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. fix: improve adjusted base comparison

    ticket: codecov/internal-issues#204
    
    Let me preface this by saying that the latest comment in the ticket doesn't seem an accurate complain
    cause looking in the logs the adjusted base coverage is 91.30752 and the head covereage is 91.24169.
    
    That being said, it's still possible that for a decent sized code base the change is less than what we
    display as a "change" (that is, the change is smaller than 0.01), but it's still a change (might be 0.0001)
    Realistically no one would care.
    
    So this change protects us by having a little wiggle room. The check would only fail if the difference is
    more than 0.01 (so the numbers in the comment would look different).
    giovanni-guidini committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4743947 View commit details
    Browse the repository at this point in the history