fix: improve adjusted base comparison #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticket: codecov/internal-issues#204 Let me preface this by saying that the latest comment in the ticket doesn't seem an accurate complain cause looking in the logs the adjusted base coverage is 91.30752 and the head covereage is 91.24169. That being said, it's still possible that for a decent sized code base the change is less than what we display as a "change" (that is, the change is smaller than 0.01), but it's still a change (might be 0.0001) Realistically no one would care. So this change protects us by having a little wiggle room. The check would only fail if the difference is more than 0.01 (so the numbers in the comment would look different).
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34150 34150
=======================================
Hits 33217 33217
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34150 34150
=======================================
Hits 33217 33217
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34150 34150
=======================================
Hits 33217 33217
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Jun 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 443 443
Lines 34879 34879
=======================================
Hits 33936 33936
Misses 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://github.com/codecov/internal-issues/issues/204
Let me preface this by saying that the latest comment in the ticket doesn't seem an accurate complain
cause looking in the logs the adjusted base coverage is 91.30752 and the head covereage is 91.24169.
That being said, it's still possible that for a decent sized code base the change is less than what we
display as a "change" (that is, the change is smaller than 0.01), but it's still a change (might be 0.0001)
Realistically no one would care.
So this change protects us by having a little wiggle room. The check would only fail if the difference is
more than 0.01 (so the numbers in the comment would look different).
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.