-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shared version #43
Conversation
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.02%
==========================================
Files 355 355
Lines 25681 25682 +1
==========================================
- Hits 25331 25328 -3
- Misses 350 354 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
re codecov/shared#13, want to get a second opinion on a question before merging:
EDIT: actually i think the current UX doesn't show the upstream repo either. the current UX groups by org/user, and upstream Rust isn't part of my own set or those of my orgs. if i log into Codecov and show the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no blocking concerns, just consider the two Qs before merging. thank you!
tasks/sync_repos.py
Outdated
@@ -89,7 +89,7 @@ async def sync_repos_using_integration(self, db_session, git, ownerid, username) | |||
with metrics.timer(f"{metrics_scope}.sync_repos_using_integration.list_repos"): | |||
repos = await git.list_repos_using_installation(username) | |||
if repos: | |||
service_ids = {repo["id"] for repo in repos} | |||
service_ids = {str(repo["repo"]["service_id"]) for repo in repos} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we just make this a string in the return format for both this and list_repos()
? i don't think we use them anywhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change in shared and updated things here accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also great catch re: .get()
vs []
Updates the
shared
version and accommodates changes from:fork
value in repo datalist_repos_using_installation