Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure service_id values are always strings #19

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

scott-codecov
Copy link
Contributor

Addresses the comment by @matt-codecov here: codecov/worker#43 (comment)

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #19 (d47b66a) into main (7d0f0ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          90       90           
  Lines        8071     8071           
  Branches     1224     1224           
=======================================
  Hits         7400     7400           
  Misses        669      669           
  Partials        2        2           
Flag Coverage Δ
python3.10.5 88.61% <ø> (ø)
python3.7.13 88.46% <ø> (ø)
python3.8.13 88.70% <ø> (ø)
python3.9.12 89.05% <ø> (ø)
rust 89.75% <ø> (ø)
smart-labels 92.18% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
shared/torngit/github.py 95.27% <ø> (ø)
shared/torngit/gitlab.py 91.77% <ø> (ø)

@scott-codecov scott-codecov merged commit 51e1131 into main Jul 31, 2023
4 checks passed
@scott-codecov scott-codecov deleted the scott/string-service-ids branch July 31, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants