feat: GithubAppInstallation model #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 375 375
Lines 30667 30721 +54
=======================================
+ Hits 30096 30150 +54
Misses 571 571
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 375 375
Lines 30667 30721 +54
=======================================
+ Hits 30096 30150 +54
Misses 571 571
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 375 375
Lines 30667 30721 +54
=======================================
+ Hits 30096 30150 +54
Misses 571 571
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 406 406
Lines 31368 31422 +54
=======================================
+ Hits 30776 30830 +54
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
giovanni-guidini
requested review from
matt-codecov,
adrian-codecov and
joseph-sentry
giovanni-guidini
added a commit
that referenced
this pull request
Jan 23, 2024
depends on: #236 context: codecov/engineering-team#970 usage of the `GithubAppInstallation` model through the worker. It still respects and doesn't affect deprecated usages of `owner.integration_id` and `repo.using_integration`, but if a ghapp exists for the owner it takes precedence over the legacy fields.
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
e15d378
to
8030169
Compare
giovanni-guidini
added a commit
that referenced
this pull request
Jan 24, 2024
depends on: #236 context: codecov/engineering-team#970 usage of the `GithubAppInstallation` model through the worker. It still respects and doesn't affect deprecated usages of `owner.integration_id` and `repo.using_integration`, but if a ghapp exists for the owner it takes precedence over the legacy fields.
These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
8030169
to
a062340
Compare
giovanni-guidini
added a commit
that referenced
this pull request
Jan 26, 2024
depends on: #236 context: codecov/engineering-team#970 usage of the `GithubAppInstallation` model through the worker. It still respects and doesn't affect deprecated usages of `owner.integration_id` and `repo.using_integration`, but if a ghapp exists for the owner it takes precedence over the legacy fields.
| GITHUB_APP_INSTALLATION_DEFAULT_NAME = "codecov_app_installation" | ||
|
|
||
|
|
||
| class GithubAppInstallation(CodecovBaseModel, MixinBaseClass): |
There was a problem hiding this comment.
Is there an easy way to test this E2E to prevent something like what happened in API?
There was a problem hiding this comment.
Unsure. I don't think we have the infra in place...
I tested locally, if that's worth anything (upload, PR comment, statuses and exploring files in the UI), but it's very much a "trust me" scenario and we know it's easy to make mistakes.
adrian-codecov
approved these changes
Jan 26, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Feb 1, 2024
depends on: #236 context: codecov/engineering-team#970 usage of the `GithubAppInstallation` model through the worker. It still respects and doesn't affect deprecated usages of `owner.integration_id` and `repo.using_integration`, but if a ghapp exists for the owner it takes precedence over the legacy fields.
giovanni-guidini
added a commit
that referenced
this pull request
Feb 1, 2024
depends on: #236 context: codecov/engineering-team#970 usage of the `GithubAppInstallation` model through the worker. It still respects and doesn't affect deprecated usages of `owner.integration_id` and `repo.using_integration`, but if a ghapp exists for the owner it takes precedence over the legacy fields.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes port codecov/codecov-api#346 to the worker so we can use them here as well.
context: codecov/engineering-team#970