Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app_installation functionality to Worker #970

Closed
Tracked by #752
trent-codecov opened this issue Jan 3, 2024 · 1 comment
Closed
Tracked by #752

Add app_installation functionality to Worker #970

trent-codecov opened this issue Jan 3, 2024 · 1 comment
Assignees
@giovanni-guidini

Comments

@trent-codecov
Copy link
Contributor

trent-codecov commented Jan 3, 2024 •
edited
Loading

Depends on #969 , create a model in the worker as well.

  • in sync_repos_using_installation(), change the UPDATE to a SELECT
  • update references to owner.integration_id and repo.using_integration such as this one
  • Rename integration_id to installation_id (except github.integration.id in codecov.yml which is an unrelated thing with the same name)

Original context
@trent-codecov trent-codecov mentioned this issue Jan 3, 2024
Closed
@trent-codecov trent-codecov mentioned this issue Jan 4, 2024
Closed
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 19, 2024
@giovanni-guidini
feat: GithubAppInstallation model
e15d378 
These changes port codecov/codecov-api#346
to the worker so we can use them here as well.

context: codecov/engineering-team#970
@giovanni-guidini giovanni-guidini mentioned this issue Jan 19, 2024
Merged
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 23, 2024
@giovanni-guidini
feat: use GithubAppInstalltion in the worker
1e19cf8 
depends on: #236

context: codecov/engineering-team#970

usage of the `GithubAppInstallation` model through the worker.
It still respects and doesn't affect deprecated usages of
`owner.integration_id` and `repo.using_integration`, but if a
ghapp exists for the owner it takes precedence over the legacy fields.
@giovanni-guidini giovanni-guidini mentioned this issue Jan 23, 2024
Merged
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 24, 2024
@giovanni-guidini
feat: GithubAppInstallation model
8030169 
These changes port codecov/codecov-api#346
to the worker so we can use them here as well.

context: codecov/engineering-team#970
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 24, 2024
@giovanni-guidini
feat: use GithubAppInstalltion in the worker
b2561e3 
depends on: #236

context: codecov/engineering-team#970

usage of the `GithubAppInstallation` model through the worker.
It still respects and doesn't affect deprecated usages of
`owner.integration_id` and `repo.using_integration`, but if a
ghapp exists for the owner it takes precedence over the legacy fields.
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 26, 2024
@giovanni-guidini
feat: GithubAppInstallation model
a062340 
These changes port codecov/codecov-api#346
to the worker so we can use them here as well.

context: codecov/engineering-team#970
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 26, 2024
@giovanni-guidini
feat: use GithubAppInstalltion in the worker
e2731f9 
depends on: #236

context: codecov/engineering-team#970

usage of the `GithubAppInstallation` model through the worker.
It still respects and doesn't affect deprecated usages of
`owner.integration_id` and `repo.using_integration`, but if a
ghapp exists for the owner it takes precedence over the legacy fields.
giovanni-guidini added a commit to codecov/worker that referenced this issue Jan 29, 2024
@giovanni-guidini
feat: GithubAppInstallation model (#236)
c8e780d 
These changes port codecov/codecov-api#346
to the worker so we can use them here as well.

context: codecov/engineering-team#970
giovanni-guidini added a commit to codecov/worker that referenced this issue Feb 1, 2024
@giovanni-guidini
feat: use GithubAppInstalltion in the worker
a2016bc 
depends on: #236

context: codecov/engineering-team#970

usage of the `GithubAppInstallation` model through the worker.
It still respects and doesn't affect deprecated usages of
`owner.integration_id` and `repo.using_integration`, but if a
ghapp exists for the owner it takes precedence over the legacy fields.
giovanni-guidini added a commit to codecov/worker that referenced this issue Feb 1, 2024
@giovanni-guidini
feat: use GithubAppInstalltion in the worker (#239)
c8afa70 
depends on: #236

context: codecov/engineering-team#970

usage of the `GithubAppInstallation` model through the worker.
It still respects and doesn't affect deprecated usages of
`owner.integration_id` and `repo.using_integration`, but if a
ghapp exists for the owner it takes precedence over the legacy fields.
@jerrodcodecov
Copy link

jerrodcodecov commented Mar 25, 2024 •
edited
Loading

@giovanni-guidini @trent-codecov can we move this to closed?

@codecov-hooky codecov-hooky bot closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovanni-guidini giovanni-guidini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trent-codecov @jerrodcodecov @giovanni-guidini