Add back previous cobertura behaviour and put newer behaviour behind config option #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-sentry
force-pushed
the
joseph/handle-previous-cobertura-behaviour
branch
from
29ec21d
to
8b23b2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 374 374
Lines 27897 27917 +20
==========================================
+ Hits 27448 27467 +19
- Misses 449 450 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 98.43% 98.42% -0.01%
==========================================
Files 348 348
Lines 27401 27421 +20
==========================================
+ Hits 26971 26990 +19
- Misses 430 431 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 98.43% 98.42% -0.01%
==========================================
Files 348 348
Lines 27401 27421 +20
==========================================
+ Hits 26971 26990 +19
- Misses 430 431 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
requested review from
giovanni-guidini,
scott-codecov and
matt-codecov
…config option Signed-off-by: joseph-sentry <[email protected]>
Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/handle-previous-cobertura-behaviour
branch
from
8b23b2b
to
6527f66
Compare
scott-codecov
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is taking the changes in #118, and putting them behind a config option in the
codecov.ymlspecificallyDepends on: codecov/shared#67