Fix cobertura XML parsing #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage ? 98.42%
=======================================
Files ? 341
Lines ? 26640
Branches ? 0
=======================================
Hits ? 26220
Misses ? 420
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 98.43% 98.44%
=======================================
Files 347 347
Lines 27226 27230 +4
=======================================
+ Hits 26801 26806 +5
+ Misses 425 424 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 98.39% 98.40%
=======================================
Files 373 373
Lines 27722 27726 +4
=======================================
+ Hits 27278 27283 +5
+ Misses 444 443 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/fix-cobertura-xml
branch
from
e0e4a2d
to
f8a0bbb
Compare
joseph-sentry
force-pushed
the
joseph/fix-cobertura-xml
branch
from
f8a0bbb
to
3737e0b
Compare
joseph-sentry
force-pushed
the
joseph/fix-cobertura-xml
branch
from
3737e0b
to
2084aa0
Compare
joseph-sentry
force-pushed
the
joseph/fix-cobertura-xml
branch
from
2084aa0
to
b6acedb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 98.43% 98.44%
=======================================
Files 347 347
Lines 27226 27230 +4
=======================================
+ Hits 26801 26806 +5
+ Misses 425 424 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes: codecov/feedback#61 Signed-off-by: joseph-sentry <[email protected]>
Fixes: codecov/feedback#67 Signed-off-by: joseph-sentry <[email protected]>
… attribute Signed-off-by: joseph-sentry <[email protected]>
Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/fix-cobertura-xml
branch
from
b6acedb
to
8aaed3e
Compare
scott-codecov
approved these changes
Oct 12, 2023
Signed-off-by: joseph-sentry <[email protected]>
Signed-off-by: joseph-sentry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Cobertura XML parsing to do case-insensitive handling of the branch attribute on a line, and to handle the case where both the condition elements and missing branches attributes don't exist on a partially covered line.
Fixes: codecov/feedback#61
Fixes: codecov/feedback#67