Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo updatestamp in upload task #150

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Oct 18, 2023

This is currently happening in the API's upload endpoint (codecov/codecov-api#200) and can actually be quite slow sometimes. Let's do it in the worker instead.

More context here: https://sentry.slack.com/archives/C0557QXEW4V/p1697657512609759

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #150 (f7ae6ef) into main (dc65d63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         373      373           
  Lines       27744    27749    +5     
=======================================
+ Hits        27300    27305    +5     
  Misses        444      444           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.23% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/tests/factories/core.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.45% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 98.27% <100.00%> (+<0.01%) ⬆️

This change has been scanned for critical changes. Learn more

@codecov-qa
Copy link

codecov-qa bot commented Oct 18, 2023

Codecov Report

Merging #150 (f7ae6ef) into main (dc65d63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         347      347           
  Lines       27248    27253    +5     
=======================================
+ Hits        26823    26828    +5     
  Misses        425      425           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.23% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/tests/factories/core.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.44% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 98.26% <100.00%> (+<0.01%) ⬆️

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 18, 2023

Codecov Report

Merging #150 (f7ae6ef) into main (dc65d63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         347      347           
  Lines       27248    27253    +5     
=======================================
+ Hits        26823    26828    +5     
  Misses        425      425           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.23% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/tests/factories/core.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.44% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 98.26% <100.00%> (+<0.01%) ⬆️

@scott-codecov scott-codecov merged commit 2b9491d into main Oct 18, 2023
25 of 26 checks passed
@scott-codecov scott-codecov deleted the scott/update-repo-updatestamp branch October 18, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants