-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only auto-activate if state has changed, remove update to repo.updatestamp #200
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 600 600
Lines 15222 15223 +1
=======================================
+ Hits 14555 14556 +1
Misses 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 600 600
Lines 15222 15223 +1
=======================================
+ Hits 14555 14556 +1
Misses 667 667
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #200 +/- ##
=====================================
Coverage 95.52 95.52
=====================================
Files 714 714
Lines 15628 15629 +1
=====================================
+ Hits 14928 14929 +1
Misses 700 700
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Purpose/Motivation
This query was quite slow at times. See here for p99 response time > 60s in some cases: https://codecov.sentry.io/performance/summary/spans/db:500d772238719a7c/?environment=production&project=5215654&query=http.method%3APOST&statsPeriod=7d&transaction=%2Fupload%2F%7Bversion%7D%2F
Presumably there's just lots of contention for that repo row and updates are waiting on locks. The actual query itself is conditional on the primary key so it's not like adding an index would speed that up or anything.
Links to relevant tickets
Depends on codecov/worker#150
What does this PR do?
repos.updatestamp
(this will now happen in the worker - see here: Update repo updatestamp in upload task worker#150)active/activated/deleted
state if it actually changed