fix: better handle missing static analysis info #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix codecov/engineering-team#650 Recently we made changes to static analysis process of the CLI so it doesn't fails completely if there are issues analysing a file or uploading it to GCS. I think this inadvertedly broke the expectation of label analysis that all files in the static analysis are uploaded and ready to be used. Or some other misterious bug is causing some snapshots to be missing This is causing issues that the label analysis is not processing correctly. So we are now guarding against missing snapshots in HEAD or BASE. Sadly for ats, it only as good as the data it has. And being conservative (and safe) is important to us. So if we can't make an educated guess about a change, the procedure so far is to just run everything. That's the fallback, assume the entire file is compromised and needs to be tested again closes codecov/engineering-team#650
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 347 347
Lines 27091 27113 +22
=======================================
+ Hits 25276 25298 +22
Misses 1815 1815
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 347 347
Lines 27091 27113 +22
=======================================
+ Hits 25276 25298 +22
Misses 1815 1815
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 371 371
Lines 27500 27522 +22
=======================================
+ Hits 27078 27100 +22
Misses 422 422
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
scott-codecov
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix codecov/engineering-team#650
Recently we made changes to static analysis process of the CLI so it doesn't fails completely
if there are issues analysing a file or uploading it to GCS.
I think this inadvertedly broke the expectation of label analysis that all files in the static analysis
are uploaded and ready to be used. Or some other misterious bug is causing some snapshots to be missing
This is causing issues that the label analysis is not processing correctly. So we are now guarding
against missing snapshots in HEAD or BASE.
Sadly for ats, it only as good as the data it has. And being conservative (and safe) is important to us.
So if we can't make an educated guess about a change, the procedure so far is to just run everything.
That's the fallback, assume the entire file is compromised and needs to be tested again
closes codecov/engineering-team#650
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.