-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed to calculate error - label_analysis task #650
Comments
giovanni-guidini
added a commit
to codecov/worker
that referenced
this issue
Oct 5, 2023
Fix codecov/engineering-team#650 Recently we made changes to static analysis process of the CLI so it doesn't fails completely if there are issues analysing a file or uploading it to GCS. I think this inadvertedly broke the expectation of label analysis that all files in the static analysis are uploaded and ready to be used. Or some other misterious bug is causing some snapshots to be missing This is causing issues that the label analysis is not processing correctly. So we are now guarding against missing snapshots in HEAD or BASE. Sadly for ats, it only as good as the data it has. And being conservative (and safe) is important to us. So if we can't make an educated guess about a change, the procedure so far is to just run everything. That's the fallback, assume the entire file is compromised and needs to be tested again closes codecov/engineering-team#650
giovanni-guidini
added a commit
to codecov/worker
that referenced
this issue
Oct 6, 2023
Fix codecov/engineering-team#650 Recently we made changes to static analysis process of the CLI so it doesn't fails completely if there are issues analysing a file or uploading it to GCS. I think this inadvertedly broke the expectation of label analysis that all files in the static analysis are uploaded and ready to be used. Or some other misterious bug is causing some snapshots to be missing This is causing issues that the label analysis is not processing correctly. So we are now guarding against missing snapshots in HEAD or BASE. Sadly for ats, it only as good as the data it has. And being conservative (and safe) is important to us. So if we can't make an educated guess about a change, the procedure so far is to just run everything. That's the fallback, assume the entire file is compromised and needs to be tested again closes codecov/engineering-team#650
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://l.codecov.dev/8Q9R8j
Actual error is
'NoneType' object has no attribute 'get_corresponding_executable_line'
The text was updated successfully, but these errors were encountered: