build: Apply recommended lint rules #3524
Conversation
Bundle ReportChanges will decrease total bundle size by 859 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## gh-eng-2124-audit-and-update-lint-rules-for-gazebo #3524 +/- ##
===================================================================================
Coverage 98.92% 98.93%
===================================================================================
Files 806 806
Lines 14372 14372
Branches 4079 4083 +4
===================================================================================
+ Hits 14218 14219 +1
+ Misses 147 146 -1
Partials 7 7
... and 8 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3524 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 806 806
Lines 14369 14372 +3
Branches 4077 4083 +6
=======================================
+ Hits 14216 14219 +3
Misses 146 146
Partials 7 7
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚨 Try these New Features:
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Bundle ReportChanges will decrease total bundle size by 859 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## gh-eng-2124-audit-and-update-lint-rules-for-gazebo #3524 +/- ##
===================================================================================
Coverage 98.92% 98.93%
===================================================================================
Files 806 806
Lines 14372 14372
Branches 4086 4083 -3
===================================================================================
+ Hits 14218 14219 +1
+ Misses 147 146 -1
Partials 7 7
... and 8 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
| @@ -31,7 +31,7 @@ const queryClient = new QueryClient({ | |||
| }) | |||
| const server = setupServer() | |||
|
|
|||
| let testLocation: { pathname: string; search: string } = { | |||
| const testLocation: { pathname: string; search: string } = { | |||
There was a problem hiding this comment.
Auto fix as this wasn't being reassigned
| @@ -82,7 +82,7 @@ describe('MyContextSwitcher', () => { | |||
| return HttpResponse.json({ data: { me: null } }) | |||
| } | |||
|
|
|||
| const orgList = !!info.variables?.after ? org2 : org1 | |||
| const orgList = info.variables?.after ? org2 : org1 | |||
There was a problem hiding this comment.
Linter autofix
| @@ -79,7 +79,7 @@ describe('useOktaConfig', () => { | |||
| }) | |||
|
|
|||
| describe('invalid schema', () => { | |||
| let consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) | |||
| const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) | |||
There was a problem hiding this comment.
Linter autofix - wasn't being reassigned
| return HttpResponse.json({ data: response }) | ||
| }) | ||
| ) | ||
| } | ||
|
|
||
| describe('when calling the mutation', () => { | ||
| let consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) | ||
| const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) |
There was a problem hiding this comment.
Linter autofix - wasn't being reassigned
| @@ -71,7 +71,7 @@ interface CreateTableArgs { | |||
| const createTable = ({ tableData, seatData, mutate }: CreateTableArgs) => { | |||
| return tableData?.map( | |||
| ({ ownerid, activated, email, isAdmin, name, username }) => { | |||
| let maxSeats = seatData?.seatsUsed === seatData?.seatsLimit | |||
| const maxSeats = seatData?.seatsUsed === seatData?.seatsLimit | |||
There was a problem hiding this comment.
Linter autofix - wasn't being reassigned
There was a problem hiding this comment.
Remove unused setup functions
| @@ -206,7 +206,7 @@ const Select = forwardRef( | |||
| { | |||
| 'border overflow-y-auto': isOpen, | |||
| }, | |||
| !!onSearch ? 'top-16' : 'top-8 rounded' | |||
| onSearch ? 'top-16' : 'top-8 rounded' | |||
There was a problem hiding this comment.
Linter autofix - removing double !!
| const toggleItem = (selectedItem) => { | ||
| isItemSelected(selectedItem, selectedItems) | ||
| ? removeSelectedItem(selectedItem) | ||
| : addSelectedItem(selectedItem) | ||
| if (isItemSelected(selectedItem, selectedItems)) { | ||
| removeSelectedItem(selectedItem) | ||
| } else { | ||
| addSelectedItem(selectedItem) | ||
| } |
There was a problem hiding this comment.
TS lint rules don't like ternaries being used unless a value is being set/returned so this is the way around that
| if (isAllButton(selectedItem)) { | ||
| reset() | ||
| } else { | ||
| toggleItem(selectedItem) | ||
| } |
There was a problem hiding this comment.
See above 👀
| } | ||
|
|
||
| const listItems = [ | ||
| SELECT_ALL_BUTTON, | ||
| ...selectedItems, | ||
| ...items?.filter((item) => !isItemSelected(item, selectedItems)), | ||
| ...(items?.filter((item) => !isItemSelected(item, selectedItems)) ?? []), |
There was a problem hiding this comment.
Handling the case where items is undefined
nicholas-codecov
changed the base branch from
main
to
gh-eng-2124-audit-and-update-lint-rules-for-gazebo
nicholas-codecov
force-pushed
the
gh-eng-2124-audit-and-update-lint-rules-for-gazebo
branch
from
614ae25
to
125652e
Compare
Description
Note
Requires #3508 to be merged before reviewing.
This PR applies the recommended rules from
eslintandtypescript-eslintTicket: codecov/engineering-team#2124
Notable Changes
eslint:recommendedandplugin:@typescript-eslint/recommendedts-expect-errorwith no message_to the argument{}toobjector correct type!!when they're not needed such as in conditionalslettoconstfor values that aren't being reassigned