build: Audit and update lint rules for Gazebo #3508

nicholas-codecov · 2024-11-18T11:34:06Z

Description

This PR removes react-scripts from Gazebo, while updating the local eslint config to match that of react-scripts so that we're able to fully remove it and it's extra deps. This PR also updates some of the already used eslint packages while I was at it.

Ticket: codecov/engineering-team#2124

Notable Changes

Add/Update/Remove lint related deps
Copy lint rules over from react-scripts
- Removed deprecated
- Updated rules for unused vars - you can use _ (underscore) now to ignore unused vars
  - Update couple of warnings for unused vars
Remove Storybook create-react-app preset (since we removed react-scripts this is no longer needed)

codecov-staging · 2024-11-18T11:36:46Z

Bundle Report

Changes will decrease total bundle size by 1.07kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.63MB	343 bytes (-0.01%) ⬇️
gazebo-staging-system	5.58MB	725 bytes (-0.01%) ⬇️

codecov · 2024-11-18T11:37:07Z

Bundle Report

Changes will decrease total bundle size by 1.07kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.58MB	725 bytes (-0.01%) ⬇️
gazebo-production-system-esm	5.63MB	343 bytes (-0.01%) ⬇️

codecov · 2024-11-18T11:37:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (aa0c312) to head (125652e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files         808      808              
  Lines       14411    14407       -4     
  Branches     4098     4091       -7     
==========================================
- Hits        14256    14252       -4     
  Misses        148      148              
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.33% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...125652e. Read the comment docs.

codecov-notifications · 2024-11-18T11:37:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files         808      808              
  Lines       14411    14407       -4     
  Branches     4091     4091              
==========================================
- Hits        14256    14252       -4     
  Misses        148      148              
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.33% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...125652e. Read the comment docs.

codecov-releaser · 2024-11-18T11:40:08Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`72eb6f6`	Mon, 18 Nov 2024 11:40:08 GMT	Expired	Expired
`cc027fc`	Mon, 18 Nov 2024 11:56:56 GMT	Expired	Expired
`9130e2c`	Mon, 18 Nov 2024 16:02:16 GMT	Expired	Expired
`4c9f62b`	Tue, 19 Nov 2024 11:39:14 GMT	Expired	Expired
`614ae25`	Thu, 21 Nov 2024 11:39:18 GMT	Expired	Expired
`125652e`	Wed, 27 Nov 2024 12:28:51 GMT	Cloud	Enterprise

codecov-qa · 2024-11-18T11:40:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (aa0c312) to head (125652e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files         808      808              
  Lines       14411    14407       -4     
  Branches     4098     4091       -7     
==========================================
- Hits        14256    14252       -4     
  Misses        148      148              
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.33% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...125652e. Read the comment docs.

codecov-public-qa · 2024-11-18T12:00:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (aa0c312) to head (125652e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files         808      808              
  Lines       14411    14407       -4     
  Branches     4091     4091              
==========================================
- Hits        14256    14252       -4     
  Misses        148      148              
  Partials        7        7

Files with missing lines	Coverage Δ
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx	`100.00% <ø> (ø)`
...rc/pages/TermsOfService/hooks/useTermsOfService.ts	`100.00% <100.00%> (ø)`
.../services/charts/useBranchCoverageMeasurements.tsx	`100.00% <ø> (ø)`
src/services/commit/useCommitTeam.tsx	`100.00% <ø> (ø)`
src/services/pull/usePull.tsx	`100.00% <ø> (ø)`
src/services/pull/usePullTeam.tsx	`100.00% <ø> (ø)`
src/services/user/useInternalUser.ts	`92.30% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.33% <ø> (-0.01%)`	⬇️
Shared	`99.33% <ø> (ø)`
UI	`99.21% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...125652e. Read the comment docs.

nicholas-codecov marked this pull request as ready for review November 18, 2024 11:50

nicholas-codecov mentioned this pull request Nov 21, 2024

build: Apply recommended lint rules #3524

Open

calvin-codecov approved these changes Nov 27, 2024

View reviewed changes

nicholas-codecov added 10 commits November 27, 2024 08:21

add new deps for eslint rules

bb27441

update eslint related packages

8210394

build out eslint config based off of react-scripts lint rules

ae6dbbe

also remove storybook create-react-app preset

1b0e991

remove duplicated or deprecated rules

b11a7fc

allow unused vars to be ignored with an underscore

35baad6

ignore errors in catch statement with underscores

bd282b0

remove unused vars for their respective type declartions

d95e238

use underscore to silence lint warning

74c9b8f

re-org rules to be split between modified base rules and custom rules

125652e

nicholas-codecov force-pushed the gh-eng-2124-audit-and-update-lint-rules-for-gazebo branch from 614ae25 to 125652e Compare November 27, 2024 12:22

nicholas-codecov added this pull request to the merge queue Nov 27, 2024

Merged via the queue into main with commit 8162361 Nov 27, 2024
61 of 62 checks passed

nicholas-codecov deleted the gh-eng-2124-audit-and-update-lint-rules-for-gazebo branch November 27, 2024 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Audit and update lint rules for Gazebo #3508

build: Audit and update lint rules for Gazebo #3508

nicholas-codecov commented Nov 18, 2024 •

edited

Loading

codecov-staging bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov-notifications bot commented Nov 18, 2024 •

edited

Loading

codecov-releaser commented Nov 18, 2024 •

edited

Loading

codecov-qa bot commented Nov 18, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 18, 2024 •

edited

Loading

build: Audit and update lint rules for Gazebo #3508

build: Audit and update lint rules for Gazebo #3508

Conversation

nicholas-codecov commented Nov 18, 2024 • edited Loading

Description

Notable Changes

codecov-staging bot commented Nov 18, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 18, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-releaser commented Nov 18, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-qa bot commented Nov 18, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Nov 18, 2024 • edited Loading

Codecov Report

nicholas-codecov commented Nov 18, 2024 •

edited

Loading

codecov-staging bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

codecov-notifications bot commented Nov 18, 2024 •

edited

Loading

codecov-releaser commented Nov 18, 2024 •

edited

Loading

codecov-qa bot commented Nov 18, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 18, 2024 •

edited

Loading