fix(memory-core): a Windows sharing violation on the head wake ticket no longer rejects the waiter - #8970
Closed
code-yeongyu wants to merge 5 commits into
Closed
fix(memory-core): a Windows sharing violation on the head wake ticket no longer rejects the waiter#8970code-yeongyu wants to merge 5 commits into
code-yeongyu wants to merge 5 commits into
Conversation
Owner
Author
|
Focused Windows soaks of the final head (windows-latest, 50 iterations each, wake-slot + recall-wake-domain + palace tests): 36327253718 success, 36327255724 success, 36327257610 success. An earlier 10-iteration soak exposed a 400 ms waiter budget in the new sharing-violation test (the follower reported busy, product unaffected); the test now uses a 10 s circuit breaker, commit 741c06a. |
code-yeongyu
marked this pull request as ready for review
September 27, 2026 15:37
code-yeongyu
force-pushed
the
fix/win-ci-kibitzer-wake-slot
branch
from
September 27, 2026 17:42
741c06a to
c28a60b
Compare
code-yeongyu
force-pushed
the
fix/win-ci-kibitzer-wake-slot
branch
from
September 27, 2026 22:47
c28a60b to
01b50bc
Compare
… keeps its place instead of rejecting the waiter (#8953) Windows can deny opening a wake ticket while its owner publishes or withdraws it (EPERM/EBUSY/EACCES). reapDeadHead threw on that, rejecting a queued waiter, which broke FIFO admission and left the stress test's remaining waiters running into later tests. The unreadable head now keeps its place until the next poll. Tests inject the sharing violation deterministically and abort and drain every waiter on teardown.
… wake ticket sharing fix
…er budget and surface their real error (#8953) The 400 ms budget covered the whole hand-off (sharing violation, holder release, head acquire and release); a slow Windows runner exceeded it and the follower reported busy (seen 3 times in 150 iterations). The budget is now a 10 s circuit breaker like the FIFO test, and a rejected follower rethrows its own error.
code-yeongyu
force-pushed
the
fix/win-ci-kibitzer-wake-slot
branch
from
September 27, 2026 23:08
01b50bc to
6d601f2
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows-only red in
createKibitzerWakeSlot"ten sessions contending for two slots ... admission is FIFO" (senpi-compatibility windows, runs 36312352680 and 36300728869), together with the palace test failures that cascaded from it in the same job.Root cause (product)
reapDeadHeadinpackages/memory-core/src/locks/recall-wake-domain.tsreads the head wake ticket to prove its owner dead. On Windows, opening a ticket while its owner is publishing or withdrawing it can fail with a sharing violation (EPERM/EBUSY/EACCES). That error was rethrown, which rejected a queued waiter. The FIFO test saw that as the next waiter "already settled" (wake-slot.test.ts:90). The remaining waiters kept polling after the failed test and threw inside later palace tests ("expected an acquired admission, got busy", with the stack pointing into wake-slot.test.ts:72).Fix
finally, so a failure can no longer leak work into later tests. The oldsettledAlreadyrace helper is replaced by asserting the admitted order and the live count after every release.build-extension.mjs --checkgreen in the container). The diff is limited to the three bundles that embed memory-core.QA & Evidence
tsgo -p packages/memory-coreand-p packages/omo-senpiexit 0. Biome clean.Fixes #8953
Refs #8250, #8324
Summary by cubic
Fixes the Windows-only FIFO admission failures in
createKibitzerWakeSlotcaused by a sharing violation when reading the head wake ticket. On Windows, opening a ticket while its owner publishes or withdraws it can fail withEPERM/EBUSY/EACCES, which previously rejected a queued waiter and let remaining waiters poll into later tests. The unreadable head ticket now keeps its place until the next normal poll; dead-owner reclamation, FIFO order, and bounded waiting are unchanged. Theomo-senpiextension bundles that embedmemory-corewere regenerated.Tests
finallyso failures can't leak into later tests.Fixes #8953.
Written for commit 6d601f2. Summary will update on new commits.