Repository navigation
test(lsp-core): synchronize unscoped applyEdit response - #8955
Closed
code-yeongyu wants to merge 1 commit into
Closed
code-yeongyu wants to merge 1 commit into
code-yeongyu wants to merge 1 commit into
Conversation
Owner
Author
|
Focused Windows soaks of this branch (windows-latest, 10 iterations each): 36322413097 success, 36322416052 success, 36322419931 success. |
code-yeongyu
marked this pull request as ready for review
September 27, 2026 15:19
code-yeongyu
force-pushed
the
fix/win-ci-lsp-applyedit
branch
from
September 27, 2026 17:28
fc5cb0d to
d156b4b
Compare
code-yeongyu
force-pushed
the
fix/win-ci-lsp-applyedit
branch
from
September 27, 2026 21:04
d156b4b to
5e17d48
Compare
code-yeongyu
force-pushed
the
fix/win-ci-lsp-applyedit
branch
from
September 27, 2026 22:27
5e17d48 to
911293e
Compare
Owner
Author
|
Run 36355338604 failed only on |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the unscoped
workspace/applyEditlease test observe the exact response event deterministically. The fixture request is now triggered bytextDocument/didOpen, after the test has armed the existing subscription-based event wait.Root cause
The failing test triggered the server request during LSP initialization and only started observing afterward. Its helper polled an event file every 10 ms and silently returned an empty array after a 2-second circuit breaker. Under the parallel Windows shard, that produced
responses[0] === undefinedeven though the product rejection path is platform-neutral.Evidence:
packages/lsp-core/src/lsp/workspace-apply-edit-lease.integration.test.ts:19-30packages/lsp-core/src/lsp/workspace-apply-edit-test-support.ts:147-159packages/lsp-core/src/lsp/fixtures/workspace-edit-server.mjs:175-187Fix
waitForEventCountBySubscriptionbefore the request trigger.didOpennotification.Evidence
bunx tsgo --noEmit -p packages/lsp-core/tsconfig.json: exit 0.git diff --check: exit 0.135e3ebc84701e309a127aa1f015fbc084e03290c97f32824d1ee61d69b36333.Focused Windows soak links will be added after all three 10-iteration runs complete.
Risks and residuals
Fixes #8954
Refs #8324
Summary by cubic
Fixes the flaky unscoped
workspace/applyEditlease test that failed intermittently on the Windows CI shard by triggering the request fromtextDocument/didOpenonly after the response subscription is armed.Bug Fixes
applyEditondidOpenwhen the test opts in viascenario.unscopedApplyEditOnDidOpen.Written for commit 911293e. Summary will update on new commits.