-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add togglability and documentation #18
Conversation
lua/nvim-biscuits/init.lua
Outdated
local make_biscuit_hl_group = function(lang) return 'BiscuitColor' .. lang end | ||
|
||
nvim_biscuits.decorate_nodes = function(bufnr, lang) | ||
if config.get_language_config(final_config, lang, "disabled") then return end | ||
|
||
if not should_render_biscuits then | ||
vim.api.nvim_buf_clear_namespace(bufnr, 0, 0, -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when I try toggle biscuits
, it disables all virtual text. I think this line is the cause. Maybe you can see this as reference. And sorry for the late reply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its because of the highlight group I am using. I can change that.
It is also an issue in another PR, so I will do that first. I will let you know when I have done that. Thinking Sunday seems likely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the fix merged in now. Let me know if that helps.
@ekickx I just pushed up a fix. Can you double check it and let me know? |
…into feature-add-togglability
It works perfectly. Thank you |
Awesome. I'm going to merge it in to main now. Thanks for the feature request and helping test it. |
You're welcome. Also thank you for accepting my feature request |
This adds and exposes a function for toggling the biscuits.
Config can be used for setting keybindings globally or per language.
The function is exposed if people would like to manually bind instead of using the config.
closes #17