Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add togglability and documentation #18

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

cmgriffing
Copy link
Contributor

This adds and exposes a function for toggling the biscuits.

Config can be used for setting keybindings globally or per language.

The function is exposed if people would like to manually bind instead of using the config.

closes #17

local make_biscuit_hl_group = function(lang) return 'BiscuitColor' .. lang end

nvim_biscuits.decorate_nodes = function(bufnr, lang)
if config.get_language_config(final_config, lang, "disabled") then return end

if not should_render_biscuits then
vim.api.nvim_buf_clear_namespace(bufnr, 0, 0, -1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So when I try toggle biscuits, it disables all virtual text. I think this line is the cause. Maybe you can see this as reference. And sorry for the late reply.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its because of the highlight group I am using. I can change that.
It is also an issue in another PR, so I will do that first. I will let you know when I have done that. Thinking Sunday seems likely.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the fix merged in now. Let me know if that helps.

@cmgriffing
Copy link
Contributor Author

@ekickx I just pushed up a fix. Can you double check it and let me know?

@cmgriffing cmgriffing self-assigned this Jul 18, 2021
@ekickx
Copy link

ekickx commented Jul 21, 2021

It works perfectly. Thank you

@cmgriffing cmgriffing merged commit f2b266f into main Jul 21, 2021
@cmgriffing
Copy link
Contributor Author

Awesome. I'm going to merge it in to main now.

Thanks for the feature request and helping test it.

@ekickx
Copy link

ekickx commented Jul 21, 2021

You're welcome. Also thank you for accepting my feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Toggle virtual text
2 participants