Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Toggle virtual text #17

Closed
ekickx opened this issue Jun 26, 2021 · 4 comments · Fixed by #18
Closed

Feature Request: Toggle virtual text #17

ekickx opened this issue Jun 26, 2021 · 4 comments · Fixed by #18
Assignees

Comments

@ekickx
Copy link

ekickx commented Jun 26, 2021

Hello, I want to request a feature to toggle the virtual text. But of course as long as you also want to add this feature.

@cmgriffing
Copy link
Contributor

I like this idea. I'm not sure what the best approach is yet. I'm guessing a configurable key binding would make sense. Right?

@cmgriffing cmgriffing self-assigned this Jun 28, 2021
@ekickx
Copy link
Author

ekickx commented Jun 28, 2021

By configurable keybinding do you mean something like this:

require('nvim-biscuits').setup({
  keys = "<Leader>tb"
})

If you mean like that, It's okay. But personally, I prefer if I can map lua function manually.

@cmgriffing
Copy link
Contributor

Ok, I have something that I think will work for everyone. The option for setting a binding via the config is there. But the function is exposed for you to bind manually instead.

Go ahead over to the PR and let me know what you think.

#18

@ekickx
Copy link
Author

ekickx commented Jul 14, 2021

Ahhh sorry for the late reply. I will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants