release-22.2.0: sql/sqlutil, descs: move TxnWithExecutor() and methods to sql.InternalExecutorFactory#90041
Closed
ZhouXing19 wants to merge 4 commits intocockroachdb:deprecate-release-22.2.0from
Closed
Conversation
Having `TxnWithExecutor()` in `descs.CollectionFactory` is unnatural, and will bring dependency loop headaches. This commit is to add the same logic under `InternalExecutorFactory`. We will remove `descs.CollectionFactory.TxnWithExecutor()` in a future PR. Release note: None
This is part of commit for a mechanical move of the `TxnWithExecutor()` function from the `descs` pkg to the `sql` package. We now use the `descs.TxnManager` interface for the same logic. Release note: None
…ith new interfaces We now use `descs.TxnManager.DescsWithTxn()` and `.DescsTxnWithExecutor()` to replace `descs.CollectionFactory.Txn()` and `.TxnWithExecutor()`. Release note: None
If a internal executor is created with a txn binding to it, it should not be used to execute statement with a nil txn. Release note: None
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
|
This change is |
Collaborator
|
Closing this PR so I can delete the temporary "dot zero" branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #89940 and 1/2 commits from #88295
/cc https://github.com/orgs/cockroachdb/teams/release
Having TxnWithExecutor() in descs.CollectionFactory is unnatural, and will bring dependency loop headaches. This commit is to move the same logic under sql.InternalExecutorFactory.
Also, if an internal executor is created with a txn binding to it, it should not be used to execute a statement with a nil txn.
link Epic CRDB-19135
Release note: None
Release justification: Bug fixes and low-risk updates to usages of internal executor.