sql: add assertion for txn passed to internal executor#88295
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Sep 26, 2022
Merged
sql: add assertion for txn passed to internal executor#88295craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ZhouXing19
changed the title
ZhouXing19
force-pushed
the
add-assert-ie-0920
branch
from
8add984 to
66d60aa
Compare
Previously, the internal executor always run queries with a nil txn, even though it's constructed with a txn binding to it. We now change it to pass the txn to the internal executor in `findNextTableToUpgrade()` Release note: None
If a internal executor is created with a txn binding to it, it should not be used to execute statement with a nil txn. Release note: None
ZhouXing19
force-pushed
the
add-assert-ie-0920
branch
from
66d60aa to
ee17a6a
Compare
Collaborator
Author
|
RFAL, thanks! |
ajwerner
approved these changes
Sep 26, 2022
Contributor
ajwerner
left a comment
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ZhouXing19)
Collaborator
Author
|
Thanks! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an internal executor is created with a txn binding to it, it should not be used to execute a statement with a nil txn.
Release note: None