ui: redirect to login page when api call is unauthorized #26053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the API handlers in CachedDataReducer were attached with a then followed by a catch, which meant errors in the dispatch of success would show up as API errors erroneously. This change moves both handlers into a single invocation of then to fix the issue. Release note: None
When we get a 401 HTTP status code, redirect to the login page. Once logout is implemented, this should do that instead, to make sure client-side state is clean. Fixes: cockroachdb#25785 Release note: None
|
This change is |
|
Thx for taking care of the promise error handlers. Will review soon! |
Merged
vilterp
approved these changes
May 25, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 29, 2018
26053: ui: redirect to login page when api call is unauthorized r=couchand a=couchand #### ui: pass both api handlers in a single then call Previously the API handlers in CachedDataReducer were attached with a then followed by a catch, which meant errors in the dispatch of success would show up as API errors erroneously. This change moves both handlers into a single invocation of then to fix the issue. Release note: None #### ui: redirect to login page when api call is unauthorized When we get a 401 HTTP status code, redirect to the login page. Once logout is implemented, this should do that instead, to make sure client-side state is clean. Fixes: #25785 Release note: None Co-authored-by: Andrew Couch <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
26062: server, ui: logout r=vilterp a=vilterp **implement logout endpoint on backend** Because of grpc-ecosystem/grpc-gateway#470, had to do an end run around gRPC. We'll need to fix grpc-gateway to pass the context through eventually, but I don't want logout to be blocked on it. **implement logout button on frontend** Makes an RPC to invalidate the session. If successful, reloads the page. Fixes #25784 Produces awesomeness when combined with #26053 Co-authored-by: Pete Vilter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui: pass both api handlers in a single then call
Previously the API handlers in CachedDataReducer were attached with
a then followed by a catch, which meant errors in the dispatch of
success would show up as API errors erroneously. This change moves
both handlers into a single invocation of then to fix the issue.
Release note: None
ui: redirect to login page when api call is unauthorized
When we get a 401 HTTP status code, redirect to the login
page. Once logout is implemented, this should do that
instead, to make sure client-side state is clean.
Fixes: #25785
Release note: None