Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: log out functionality #25784

Closed
couchand opened this issue May 21, 2018 · 0 comments · Fixed by #26062
Closed

ui: log out functionality #25784

couchand opened this issue May 21, 2018 · 0 comments · Fixed by #26062
Assignees
@vilterp
Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
2.1

Comments

@couchand
Copy link
Contributor

Add the ability to log out of the web UI. An API endpoint to destroy the session, a logout button in the sidebar, etc.
@couchand couchand added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-webui-security labels May 21, 2018
@couchand couchand added this to the 2.1 milestone May 21, 2018
@couchand couchand mentioned this issue May 21, 2018
Closed
@vilterp vilterp mentioned this issue May 24, 2018
Merged
craig bot pushed a commit that referenced this issue May 31, 2018
Merge #26062
e6bbb2e 
26062: server, ui: logout r=vilterp a=vilterp

**implement logout endpoint on backend**

Because of grpc-ecosystem/grpc-gateway#470, had to do an end run around gRPC. We'll need to fix grpc-gateway to pass the context through eventually, but I don't want logout to be blocked on it.

**implement logout button on frontend**

Makes an RPC to invalidate the session. If successful, reloads the page.

Fixes #25784 
Produces awesomeness when combined with #26053 

Co-authored-by: Pete Vilter <[email protected]>
@craig craig bot closed this as completed in #26062 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilterp vilterp

Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

server, ui: logout vilterp/cockroach
2 participants
@vilterp @couchand