-
Notifications
You must be signed in to change notification settings - Fork 4k
rpc, server: add DRPC support for node join RPC #157993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
7538369 to
d833a9c
Compare
d833a9c to
04d753d
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
04d753d to
4cf29a0
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
DRPC is currently disabled by default and can be enabled via the `rpc.experimental_drpc.enabled` cluster setting. Some code paths, such as command-line tools, don't have access to this setting. This change introduces a `--use-new-drpc` flag for start commands to enable DRPC in those cases. Epic: CRDB-55200 Fixes: cockroachdb#155592 Release note: None
d0631e1 to
753afff
Compare
This change enables the use of DRPC for the node join RPC when the `--use-new-rpc` flag is set, and defaults to gRPC otherwise. Epic: CRDB-51459 Fixed: cockroachdb#149600 Release note: None
753afff to
bd11b0a
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
🔴 This change is stacked on top of this DRPC change.
DRPC is currently disabled by default and can be enabled via the
rpc.experimental_drpc.enabledcluster setting. Some code paths, such as command-line tools, don't have access to this setting. This change introduces a--use-new-drpcflag for start commands to enable DRPC in those cases. This change enables the use of DRPC for the node join RPC when the--use-new-rpcflag is set, and defaults to gRPC otherwise.Epic: CRDB-55200, CRDB-51459
Fixes: #155592, #149600
Release note: None