wip: do_not_merge

Author: cthumuluru-crdb

go.mod

@@ -526,7 +526,7 @@ replace github.com/docker/docker => github.com/moby/moby v24.0.6+incompatible
 
 replace github.com/gogo/protobuf => github.com/cockroachdb/gogoproto v1.3.3-0.20241216150617-2358cdb156a1
 
-replace storj.io/drpc => github.com/cthumuluru-crdb/drpc v0.0.0-20251118112210-c686eec55198
+replace storj.io/drpc => ../drpc
 
 // Note: This forked dependency adds a commit that opens up some
 // private APIs to enable us to make some perf improvements to

pkg/cli/context.go

@@ -210,6 +210,7 @@ func setCliContextDefaults() {
 	cliCtx.ambiguousLogDir = false
 	cliCtx.logOverrides.reset()
 	cliCtx.showVersionUsingOnlyBuildTag = false
+	cliCtx.UseDRPC = true
 }
 
 // sqlConnContext captures the connection configuration for all SQL

pkg/rpc/drpc.go

@@ -9,6 +9,7 @@ import (
 	"context"
 	"math"
 	"net"
+	"runtime/debug"
 	"time"
 
 	"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
@@ -79,6 +80,7 @@ type closeEntirePoolConn struct {
 }
 
 func (c *closeEntirePoolConn) Close() error {
+	log.Ops.Infof(context.Background(), "(chandrat) poolConn.Close() called: %s", string(debug.Stack()))
 	_ = c.Conn.Close()
 	return c.pool.Close()
 }

pkg/rpc/rpcbase/nodedialer.go

@@ -16,7 +16,7 @@ import (
 	"storj.io/drpc"
 )
 
-var envExperimentalDRPCEnabled = envutil.EnvOrDefaultBool("COCKROACH_EXPERIMENTAL_DRPC_ENABLED", false)
+var envExperimentalDRPCEnabled = envutil.EnvOrDefaultBool("COCKROACH_EXPERIMENTAL_DRPC_ENABLED", true)
 
 // ExperimentalDRPCEnabled determines whether a drpc server accepting BatchRequest
 // is enabled. This server is experimental and completely unsuitable to production

pkg/server/init.go

@@ -449,9 +449,8 @@ func (s *initServer) startJoinLoop(ctx context.Context, stopper *stop.Stopper) (
 func (s *initServer) attemptJoinTo(
 	ctx context.Context, addr string,
 ) (*kvpb.JoinNodeResponse, error) {
-	var useDRPC bool = false
 	var initClient kvpb.RPCNodeClient
-	if !useDRPC {
+	if !s.config.useDRPC {
 		dialOpts, err := s.config.getGRPCDialOpts(ctx, addr, rpcbase.SystemClass)
 		if err != nil {
 			return nil, err
@@ -605,6 +604,9 @@ type initServerCfg struct {
 	// getDRPCDialOpts retrieves the DRPC dial options to use to issue Join RPCs.
 	getDRPCDialOpts func(ctx context.Context, target string, class rpcbase.ConnectionClass) ([]drpcclient.DialOption, error)
 
+	// useDRPC indicates whether to use DRPC as the RPC framework instead of gRPC.
+	useDRPC bool
+
 	// bootstrapAddresses is a list of node addresses (populated using --join
 	// addresses) that is used to form a connected graph/network of CRDB servers.
 	// Once a strongly connected graph is constructed, it suffices for any node in
@@ -664,6 +666,7 @@ func newInitServerConfig(
 		defaultZoneConfig:       cfg.DefaultZoneConfig,
 		getGRPCDialOpts:         getGRPCDialOpts,
 		getDRPCDialOpts:         getDRPCDialOpts,
+		useDRPC:                 cfg.UseDRPC,
 		bootstrapAddresses:      bootstrapAddresses,
 		testingKnobs:            cfg.TestingKnobs,
 	}