Skip to content

kvserver: default ReplicateQueueMaxSize to math.MaxInt64 #152825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 1 commit into from
Sep 3, 2025
Merged

kvserver: default ReplicateQueueMaxSize to math.MaxInt64 #152825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/kv/kvserver/replicate_queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package kvserver
import (
"context"
"fmt"
"math"
"time"

"github.com/cockroachdb/cockroach/pkg/gossip"
Expand Down Expand Up @@ -109,7 +110,7 @@ var ReplicateQueueMaxSize = settings.RegisterIntSetting(
"maximum number of replicas that can be queued for replicate queue processing; "+
"when this limit is exceeded, lower priority (not guaranteed to be the lowest) "+
"replicas are dropped from the queue",
defaultQueueMaxSize,
math.MaxInt64,
settings.WithValidateInt(func(v int64) error {
if v < defaultQueueMaxSize {
return errors.Errorf("cannot be set to a value lower than %d: %d", defaultQueueMaxSize, v)
Expand Down