kvserver: default ReplicateQueueMaxSize to math.MaxInt64 #152825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Previously, the maximum size of the replicate queue was made configurable via a cluster setting, since replica item structs are small and enforcing the a max size seemed unnecessary. This commit sets the default replicate queue size to MaxInt64. This allows more backing time on the master since we plan to backport the change and give customers the option to set it to MaxInt64. If this behavior proves stable, MaxInt64 will become the default replicate queue size in future releases as well.
wenyihu6
force-pushed
the
maxsizedefault
branch
from
18c6aa6 to
b7669c9
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
tbg
approved these changes
Sep 2, 2025
Contributor
Author
|
TFTR! bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
152825: kvserver: default ReplicateQueueMaxSize to math.MaxInt64 r=tbg a=wenyihu6 Previously, the maximum size of the replicate queue was made configurable via a cluster setting, since replica item structs are small and enforcing the a max size seemed unnecessary. This commit sets the default replicate queue size to MaxInt64. This allows more baking time on the master since we plan to backport the change and give customers the option to set it to MaxInt64. If this behavior proves stable, MaxInt64 will become the default replicate queue size in future releases as well. Epic: none Release note: none Co-authored-by: wenyihu6 <[email protected]>
Contributor
Author
|
bors retry |
Contributor
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the maximum size of the replicate queue was made configurable via a
cluster setting, since replica item structs are small and enforcing the a max
size seemed unnecessary. This commit sets the default replicate queue size to
MaxInt64. This allows more baking time on the master since we plan to backport
the change and give customers the option to set it to MaxInt64. If this behavior
proves stable, MaxInt64 will become the default replicate queue size in future
releases as well.
Epic: none
Release note: none