Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: store.Enqueue shouldn't start verbose tracing #132713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 17, 2024

  1. kvserver: store.Enqueue shouldn't start verbose tracing

    Previously in server.Enqueue, we unconditionally started verbose
    tracing. This is expensive and unnessary since most traces were never
    processed. Additionally, with the new raft level logging for verbose
    traces this resulted in unnecessary traces being created and logged to
    the main cockroach.log. This change removes the automatic tracing inside
    Enqueue and instead converts tests and callers to explicitly start a
    span prior to calling the queue.
    
    As part of this change the Enqueue method no longer returns a Recording.
    
    Epic: none
    
    Release note: None
    andrewbaptist committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d90afb2 View commit details
    Browse the repository at this point in the history