-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: store.Enqueue shouldn't start verbose tracing #132713
Open
andrewbaptist
wants to merge
1
commit into
cockroachdb:master
Choose a base branch
from
andrewbaptist:2024-10-15-change-logging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
kvserver: store.Enqueue shouldn't start verbose tracing #132713
andrewbaptist
wants to merge
1
commit into
cockroachdb:master
from
andrewbaptist:2024-10-15-change-logging
+136
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
andrewbaptist
force-pushed
the
2024-10-15-change-logging
branch
from
October 16, 2024 04:37
27306e3
to
b64a8cf
Compare
Making this change enables default raft logging as part of #131850. |
andrewbaptist
changed the title
kvserver: don't start unrequested verbose logging
kvserver: store.Enqueue shouldn't start verbose tracing
Oct 16, 2024
andrewbaptist
force-pushed
the
2024-10-15-change-logging
branch
2 times, most recently
from
October 16, 2024 18:15
a25f8ea
to
df5523f
Compare
andrewbaptist
requested review from
jeffswenson,
angles-n-daemons and
rytaft
and removed request for
a team
October 16, 2024 18:16
Previously in server.Enqueue, we unconditionally started verbose tracing. This is expensive and unnessary since most traces were never processed. Additionally, with the new raft level logging for verbose traces this resulted in unnecessary traces being created and logged to the main cockroach.log. This change removes the automatic tracing inside Enqueue and instead converts tests and callers to explicitly start a span prior to calling the queue. As part of this change the Enqueue method no longer returns a Recording. Epic: none Release note: None
There are only 3 meaningful "non-test" changes, and only the first one changes any behavior.
|
andrewbaptist
force-pushed
the
2024-10-15-change-logging
branch
from
October 16, 2024 18:44
df5523f
to
2e54d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in server.Enqueue, we unconditionally started verbose
tracing. This is expensive and unnessary since most traces were never
processed. Additionally, with the new raft level logging for verbose
traces this resulted in unnecessary traces being created and logged to
the main cockroach.log. This change removes the automatic tracing inside
Enqueue and instead converts tests and callers to explicitly start a
span prior to calling the queue.
As part of this change the Enqueue method no longer returns a Recording.
Epic: none
Release note: None