machines: disable pxe booting when a user selected session connection #12393
Conversation
|
Needs to rebase to master since #12367 changed tests names |
| @@ -596,7 +599,7 @@ class CreateVmModal extends React.Component { | |||
| this.setState({ [key]: value }); | |||
| if (this.state.sourceType == PXE_SOURCE) { | |||
| // If the installation source mode is PXE refresh the list of available networks | |||
| this.onValueChanged('sourceType', PXE_SOURCE); | |||
| this.onValueChanged('sourceType', LOCAL_INSTALL_MEDIA_SOURCE); | |||
There was a problem hiding this comment.
I don't understand this change.
There was a problem hiding this comment.
Ups, I forgot '&& value == LIBVIRT_SESSION_CONNECTION'
Basically when a user switches back to session we need to reset the choice of installation source if before they had chosen PXE, since the selection would not be valid any more.
There was a problem hiding this comment.
I see. So the comment should rather say "When changing to session connection, reset media source"?
|
#12388 introduced almost (but not quite) the same change to Select, so this needs rebasing now. |
KKoukiou
force-pushed
the
pxe-non-system
branch
2 times, most recently
from
6cb38f9 to
53ac1c4
Compare
KKoukiou
added
release-blocker
| <Select.SelectEntry title={connectionName == 'session' ? _("Network Boot is available only when using System connection") : null} | ||
| disabled={connectionName == 'session'} | ||
| data={PXE_SOURCE} | ||
| key={PXE_SOURCE}>{_("Network Boot (PXE)")}</Select.SelectEntry> } |
There was a problem hiding this comment.
Missing line break here? (But not important enough to re-push, as long as eslint is happy)
| @@ -596,7 +599,7 @@ class CreateVmModal extends React.Component { | |||
| this.setState({ [key]: value }); | |||
| if (this.state.sourceType == PXE_SOURCE) { | |||
| // If the installation source mode is PXE refresh the list of available networks | |||
| this.onValueChanged('sourceType', PXE_SOURCE); | |||
| this.onValueChanged('sourceType', LOCAL_INSTALL_MEDIA_SOURCE); | |||
There was a problem hiding this comment.
I see. So the comment should rather say "When changing to session connection, reset media source"?
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1731803