machines: handle pools which don't support CreateVol API in add disk dialog #12388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janotomko
reviewed
Jul 22, 2019
…ialog Show them in the dropdown list but disable the pools for which the CreateVol API is not supported. Relevant to https://bugzilla.redhat.com/show_bug.cgi?id=1731849
|
Needs to rebase to master since #12367 changed tests names |
KKoukiou
changed the title
It's clean from machines failures, I would skip rebasing unless there are some review comments. |
martinpitt
approved these changes
Jul 23, 2019
| @@ -92,13 +92,15 @@ Select.propTypes = { | |||
| * Expected properties: | |||
| * - data (required), will be passed to the select's onChange callback | |||
| * - disabled (optional): whether or not the entry is disabled. | |||
| * - title (optional): acts as a tooltip to the option entry | |||
There was a problem hiding this comment.
This collides with (almost but not quite) the same change in PR #12393. But fine to land this PR first, and rebase the other one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show them in the dropdown list but disable the pools for which the
CreateVol API is not supported.
Relevant to https://bugzilla.redhat.com/show_bug.cgi?id=1731849