Fixes and testing of commit #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eeeh, so it seems does not coredump anymore, but also does not show any error? I'll debug it locally. |
|
It reports error, does not coredump, but we close the dialog. This needs to be fixed. |
marusak
added a commit
to marusak/cockpit-podman
that referenced
this pull request
Jan 7, 2020
Issue containers/podman#3897 has been fixed a few months ago, it reached Fedora 30 and 31 as well as RHEL 8.2. Closes cockpit-project#284
|
Ok, so it was a real issue. I also noticed another problem, so sent fix for it here as well. |
marusak
commented
Jan 7, 2020
| @@ -267,16 +267,13 @@ class TestApplication(testlib.MachineCase): | |||
| b.click(".modal-dialog div .pf-c-alert .pf-c-button") | |||
| b.wait_not_present(".modal-dialog div .alert") | |||
|
|
|||
| # HACK: Disable checking for varlink error since it makes podman to coredump | |||
| # When hack removed, don't forget to also do the check for user containers | |||
There was a problem hiding this comment.
before someone points this out, we run this part of test on both user container and system one as well.
martinpitt
requested changes
Jan 8, 2020
Otherwise the caller does not know that the command failed.
Issue containers/podman#3897 has been fixed a few months ago, it reached Fedora 30 and 31 as well as RHEL 8.2. Closes cockpit-project#284
And not stay in the `progress` state - where `Commit` button is disabled and spinner is visible.
martinpitt
approved these changes
Jan 8, 2020
marusak
added a commit
that referenced
this pull request
Jan 8, 2020
Issue containers/podman#3897 has been fixed a few months ago, it reached Fedora 30 and 31 as well as RHEL 8.2. Closes #284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue containers/podman#3897 has been fixed a
few months ago, it reached Fedora 30 and 31 as well as RHEL 8.2.
^^ I haven't tested it, this is what I hope is true. Maybe it needs to be skipped on rhel-8-1, and maybe not (if the broken version never made it into 8.1). Let's see what tests say.