When committing fails, dialog should go to previous state

And not stay in the `progress` state - where `Commit` button is disabled and spinner is visible.
cockpit-project · Jan 7, 2020 · b1bf370 · b1bf370
1 parent 77255f2
commit b1bf370
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/ContainerCommitModal.jsx b/src/ContainerCommitModal.jsx
@@ -102,7 +102,8 @@ class ContainerCommitModal extends React.Component {
                 .catch(ex => {
                     this.setState({
                         dialogError: cockpit.format(_("Failed to commit container $0"), this.props.container.names),
-                        dialogErrorDetail: cockpit.format("$0: $1", ex.error, ex.parameters && ex.parameters.reason)
+                        dialogErrorDetail: cockpit.format("$0: $1", ex.error, ex.parameters && ex.parameters.reason),
+                        commitInProgress: false
                     });
                 });
     }

diff --git a/test/check-application b/test/check-application
@@ -273,6 +273,7 @@ class TestApplication(testlib.MachineCase):
         b.wait_present('.modal-dialog div:contains("io.podman.ErrorOccurred")')
         b.click(".modal-dialog div .pf-c-alert .pf-c-button")
         b.wait_not_present(".modal-dialog div .alert")
+        b.wait_present(".modal-dialog div .btn-ctr-commit:not([disabled])")
 
         b.click(".btn-ctr-cancel-commit")