Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ip from 1.1.8 to 2.0.1 #1451

Closed
wants to merge 1 commit into from
Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 19, 2024

Bumps ip from 1.1.8 to 2.0.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@github-actions github-actions bot changed the title [no-test]: Bump ip from 1.1.8 to 2.0.1 Bump ip from 1.1.8 to 2.0.1 Feb 19, 2024
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 2.0.1.
- [Commits](indutny/node-ip@v1.1.8...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@martinpitt martinpitt force-pushed the dependabot/npm_and_yarn/ip-2.0.1 branch from 115559b to 84dc2ab Compare February 19, 2024 22:04
@martinpitt
Copy link
Member

Yeah, this is nonsense:

✘ [ERROR] Could not resolve "os"

    node_modules/ip/lib/ip.js:3:19:
      3 │ const os = require('os');
        ╵                    ~~~~

This must be fixed in the ip module itself, and reported first.

@jelly
Copy link
Member

jelly commented Feb 20, 2024

Yeah, this is nonsense:

✘ [ERROR] Could not resolve "os"

    node_modules/ip/lib/ip.js:3:19:
      3 │ const os = require('os');
        ╵                    ~~~~

This must be fixed in the ip module itself, and reported first.

Don't think so, this is node-ip so is supposed to work with a node env not a browser env. Interestingly the one of the hints I found is indutny/node-ip#127

And hint here #521

The strange part is, the old module already required os

   1   │ var ip = exports;
   2   │ var { Buffer } = require('buffer');
   3   │ var os = require('os');

@martinpitt martinpitt self-assigned this Feb 22, 2024
martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Feb 22, 2024
`ip` is a node.js module, and was never meant for running in a browser.
It magically happened to work until version 1.1.8 despite it doing
things like `require('buffer')` (i.e. not an ESM).

In version 2.0.1 this broke completely as it tries to `require('os')`.
Replace this with https://www.npmjs.com/package/ipaddr.js which has a
comparable API and size (the actually bundled library is 12 KB for both
modules).

Closes cockpit-project#1451
@martinpitt
Copy link
Member

Fixed in #1455

martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Feb 22, 2024
`ip` is a node.js module, and was never meant for running in a browser.
It magically happened to work until version 1.1.8 despite it doing
things like `require('buffer')` (i.e. not an ESM).

In version 2.0.1 this broke completely as it tries to `require('os')`.
Replace this with https://www.npmjs.com/package/ipaddr.js which has a
comparable API and size (the actually bundled library is 12 KB for both
modules).

Closes cockpit-project#1451
@jelly jelly closed this in #1455 Feb 22, 2024
jelly pushed a commit that referenced this pull request Feb 22, 2024
`ip` is a node.js module, and was never meant for running in a browser.
It magically happened to work until version 1.1.8 despite it doing
things like `require('buffer')` (i.e. not an ESM).

In version 2.0.1 this broke completely as it tries to `require('os')`.
Replace this with https://www.npmjs.com/package/ipaddr.js which has a
comparable API and size (the actually bundled library is 12 KB for both
modules).

Closes #1451
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 22, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ip-2.0.1 branch February 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants