-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ip from 1.1.8 to 2.0.1 #1451
Conversation
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 2.0.1. - [Commits](indutny/node-ip@v1.1.8...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
115559b
to
84dc2ab
Compare
Yeah, this is nonsense:
This must be fixed in the ip module itself, and reported first. |
Don't think so, this is And hint here #521 The strange part is, the old module already required os
|
`ip` is a node.js module, and was never meant for running in a browser. It magically happened to work until version 1.1.8 despite it doing things like `require('buffer')` (i.e. not an ESM). In version 2.0.1 this broke completely as it tries to `require('os')`. Replace this with https://www.npmjs.com/package/ipaddr.js which has a comparable API and size (the actually bundled library is 12 KB for both modules). Closes cockpit-project#1451
Fixed in #1455 |
`ip` is a node.js module, and was never meant for running in a browser. It magically happened to work until version 1.1.8 despite it doing things like `require('buffer')` (i.e. not an ESM). In version 2.0.1 this broke completely as it tries to `require('os')`. Replace this with https://www.npmjs.com/package/ipaddr.js which has a comparable API and size (the actually bundled library is 12 KB for both modules). Closes cockpit-project#1451
`ip` is a node.js module, and was never meant for running in a browser. It magically happened to work until version 1.1.8 despite it doing things like `require('buffer')` (i.e. not an ESM). In version 2.0.1 this broke completely as it tries to `require('os')`. Replace this with https://www.npmjs.com/package/ipaddr.js which has a comparable API and size (the actually bundled library is 12 KB for both modules). Closes #1451
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ip from 1.1.8 to 2.0.1.
Commits
3b0994a
2.0.132f468f
lib: fixed CVE-2023-42282 and added unit test4b2f4e7
2.0.0369d56d
lib: use Buffer.allocDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions