Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a different IP implementation #521

Closed
jelly opened this issue Jan 13, 2022 · 2 comments
Closed

Switch to a different IP implementation #521

jelly opened this issue Jan 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jelly
Copy link
Member

jelly commented Jan 13, 2022

In our webpack.config.js we have a todo about the ip module:

        // TODO: The following fallbacks are needed for ip module - replace this module with one better maintained
        fallback: {
            "browser": false,
            "os": false,
            "buffer": require.resolve("buffer"),
        }

In src/components/networks/utils.js we use the ip module to validate various parts of IP address validity, netmask, broadcast address, format, etc.

A promising candidate is ipaddr.js, no external deps.
Alternative ip-address

@KKoukiou
Copy link
Collaborator

Latest version 2.0.0 solves the buffer ssue but the 'os' workaround is still needed.
Opened an upstream issue for this indutny/node-ip#127

@marusak marusak added the enhancement New feature or request label Dec 14, 2023
@jelly
Copy link
Member Author

jelly commented Sep 5, 2024

We now use ipaddr.js f27fc31

@jelly jelly closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants