Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest_install: Move manifest install to repo #2111

Merged

Conversation

kosstennbl
Copy link
Collaborator

Description

Problem explained in referenced issue.

Move "installation methods" enum from helm repo
Move Manifest-related functionality ("Manifest" module) from helm repo

Issues:

Refs: #2105

@kosstennbl kosstennbl changed the title draft: manifest_install: Move manifest install to repo Draft: manifest_install: Move manifest install to repo Jul 18, 2024
@kosstennbl kosstennbl force-pushed the manifest_installation_transfer branch from 3e4001c to 0603f7b Compare July 18, 2024 18:55
@kosstennbl kosstennbl changed the title Draft: manifest_install: Move manifest install to repo manifest_install: Move manifest install to repo Jul 18, 2024
@kosstennbl
Copy link
Collaborator Author

Should be merged first, then respective changes (removals) are needed to be done in Helm repo.

Move installation methods enum from helm repo
Move Manifest-related functionality from helm repo

Refs: cnti-testcatalog#2105
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl force-pushed the manifest_installation_transfer branch from 0603f7b to 85c0926 Compare July 19, 2024 09:50
@kosstennbl kosstennbl requested review from martin-mat and svteb July 19, 2024 09:51
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@rich-l rich-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit 857701c into cnti-testcatalog:main Jul 24, 2024
87 checks passed
@kosstennbl kosstennbl deleted the manifest_installation_transfer branch July 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants