Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Separate manifest installation mode from helm #2105

Closed
kosstennbl opened this issue Jul 12, 2024 · 0 comments
Closed

[Feature] Separate manifest installation mode from helm #2105

kosstennbl opened this issue Jul 12, 2024 · 0 comments
Assignees
@kosstennbl
Labels
enhancement New feature or request

Comments

@kosstennbl
Copy link
Collaborator

Currently we have 3 installation methods: ManifestDirectory, HelmDirectory, HelmChart.
ManifestDirectory installation mode works completely independently from Helm, it uses KubectlClient to install cnf from manifests.

Issue is that the code that is needed for ManifestDirectory install mode functionality - placed in Helm library of CNF-testsuite project.
I think, that this code should be separated from Helm library and be an independent module in Testsuite.
Also, in my opinion, InstallMethod enum shouln't be bound to Helm library either. It should be an internal testsuite thing.
@kosstennbl kosstennbl added the enhancement New feature or request label Jul 12, 2024
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Jul 18, 2024
manifest_install: Move manifest install to repo
3e4001c 
Move installation methods enum from helm repo
Move Manifest-related functionality from helm repo

Refs: cnti-testcatalog#2105
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Jul 18, 2024
Merged
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Jul 18, 2024
manifest_install: Move manifest install to repo
0603f7b 
Move installation methods enum from helm repo
Move Manifest-related functionality from helm repo

Refs: cnti-testcatalog#2105
Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Jul 19, 2024
manifest_install: Move manifest install to repo
85c0926 
Move installation methods enum from helm repo
Move Manifest-related functionality from helm repo

Refs: cnti-testcatalog#2105
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Jul 22, 2024
Merged
martin-mat pushed a commit that referenced this issue Jul 24, 2024
manifest_install: Move manifest install to repo (#2111)
857701c 
Move installation methods enum from helm repo
Move Manifest-related functionality from helm repo

Refs: #2105

Signed-off-by: Konstantin Yarovoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kosstennbl kosstennbl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kosstennbl